Expected end of statement

tbig · #1 (**permalink**) 03-28-04, 06:46 PM

Hey guys,

I have a if/then statement with a link, and a variable from the DB called into it. The problem is, the variable from the DB won't show. Here's what I have:

<%
If rs("approved") = 0 then
Response.write "<a href='view.asp?approve="&id&"'>Approve</a>"

Else

Response.write "<font size='1' font color='red'>Approved</font>"
End if
%>

With the script above, it shows the link and all, just the ID is missing, therefore the script won't work. I come out with 'view.asp?approve='.

Any help?

af11kcc · #2 (**permalink**) 03-28-04, 11:26 PM

Where are you getting ID from?

MadDog · #3 (**permalink**) 03-29-04, 12:06 PM

Lets see the full code...

tbig · #4 (**permalink**) 03-29-04, 01:16 PM

<%
'*** Deletes our record
if request.querystring("delete") <> "" then
id = request.querystring("delete")

rs.open "SELECT * FROM events WHERE id = "& id &"",conn,3,3
rs.delete
rs.update
response.redirect "view.asp"
rs.close
end if
%>

<%
'***Approves event
if request.querystring("approve") <> "" then
id = request.querystring("approve")

rs.open "SELECT * FROM events WHERE id="&id&"" ,conn,3,3
rs("approved") = 1
rs.update
response.redirect "view.asp"
rs.close
end if
%>

<%
'*** Selects our data
rs.open "SELECT * FROM events ORDER BY Event_Name ASC" ,conn
%>
<html>

<head>
<title>Miami Events: Events</title>
</head>

<link rel="stylesheet" type="text/css" href="../zma.css">
<body>

<div align="center">
<center>
<table border="2" cellpadding="0" cellspacing="0" style="border-collapse: collapse" bordercolor="#111111" width="75%" id="AutoNumber1" height="489">
<tr>
<td width="100%" height="59" bgcolor="#FFFFFF">
</td>
</tr>
<tr>
<td width="100%" height="461" bgcolor="#FFFFFF">
<div align="center">
<center>
<table border="0" cellpadding="0" cellspacing="0" style="border-collapse: collapse" bordercolor="#111111" width="65%" id="AutoNumber2" height="221">
<tr>
<td width="100%" height="221">
<table border="0" cellpadding="0" cellspacing="0" style="border-collapse: collapse" bordercolor="#111111" width="100%" id="AutoNumber3">
<tr>
<td width="100%">
<p align="center"><a title="Back to ADMIN" href="index.asp">Back
to ADMIN</a></p>
</td>
</tr>
</table>
<p> </p>
<table border="0" cellpadding="0" cellspacing="0" style="border-collapse: collapse" bordercolor="#111111" width="100%" id="AutoNumber4" height="31">
<tr>
<td width="54%" height="15">
<h3>Name:</h3>
</td>
<td width="13%" height="15">
<h3>Edit:</h3>
</td>
<td width="15%" height="15">
<h3>Approve:</h3>
</td>
<td width="36%" height="15">
<h3>Delete</h3>
</td>
</tr>
<% Do while not rs.EOF
If rs.eof then
response.write "There are no events in the database"
end if
%>
<tr>
<td width="54%" height="20">
<p align="center"><%=rs("event_name")%></p>
</td>
<td width="13%" height="20">
<p align="center"><a href="eventdetails.asp?id=<%=rs("id")%>">
<img border="0" src="../images/edit.jpg"></a></p>
</td>
<td width="15%" height="20" align="center">
<%
If rs("approved") = 0 then
Response.write "<a href='view.asp?approve="&id&"'>Approve</a>"

Else

Response.write "<font size='1' font color='red'>Approved</font>"
End if
%></td>
<p></p>
<td width="36%" height="20">
<p align="center"><a href="view.asp?delete=<%=rs("id")%>">
<img border="0" src="../images/x.jpg"></a></p>
</td>
</tr>
<%
rs.MoveNext
loop
%>
</table>
</td>
</tr>
</table>
</center>
</div>
</td>
</tr>
</table>
</center>
</div>

</body>

</html>
<%rs.close%>

-----------------------------------------------------------

It works fine if I don't have it in the rsponse.write "", but when it's in it, doesn't work

MadDog · #5 (**permalink**) 03-29-04, 11:08 PM

The problem is that you are getting the ID after someone has submitted it. Remove all the "Request.QueryString("ID")" from the script and add it to the top and outside the IF statements.

tbig · #6 (**permalink**) 03-30-04, 02:47 PM

Quote:

Originally Posted by MadDog

The problem is that you are getting the ID after someone has submitted it. Remove all the "Request.QueryString("ID")" from the script and add it to the top and outside the IF statements.

the ID comes from the database. It should write into the link there, then move on to the next record, until RS.EOF. Beasically it's just writing from the database

af11kcc · #7 (**permalink**) 03-30-04, 02:51 PM

Quote:

Originally Posted by tbig

the ID comes from the database. It should write into the link there, then move on to the next record, until RS.EOF. Beasically it's just writing from the database

Did you try MadDog's suggestion?

tbig · #8 (**permalink**) 03-30-04, 03:09 PM

Quote:

Originally Posted by af11kcc

Did you try MadDog's suggestion?

Yeah

The function works fine when the operator is there. THe only problem is getting the ID to show afater approve in the link.
example:

approve=(id of event here)

MadDog · #9 (**permalink**) 03-30-04, 08:21 PM

You need to add one of the two (depends on what you are trying to do):

id = Clng(rs("ID"))

or

id = Clng(Request.QueryString("ID"))

The problem is that you dont have the ID set to anything after a link has been approved.

tbig · #10 (**permalink**) 03-31-04, 01:44 PM

I got it going. I took out the "response.write" and just did "then %> (HTML here) <%else%> and so on.

Thanks for the help