[w2n]

In my first try, with your last code, it is NOT working! I just cliked the link, and it opens up in a new browser window, but, the actual URL, not the URL with click tracking. I didn't right click the link and opened it in that way. Just a simple left click! Any idea, why it is not working?

[TwoD]

The codes are identical except for the whitespacing and the line in the if-statment. That line was all I changed in the actual script.

I put the onload function there since it's much safer to run the code after the code has been completely loaded and the DOM is complete, otherwise there's a risk some links/images are not found.
Also, the code runs so fast that the user wouldn't be able to click a link before it's done.

[w2n]

I have just tested again with the *exact* code you have provided in this post. It is NOT working. Is it really necessary to create a fnction (findAllLinks) and that onLoad function? Can't I put the code normall, just before the </body> tag? Anyway, it's not working anyway, so, please delete the function (replaceImgPaths) and make it (findAllLinks) work only!

Originally Posted by TwoD

The modifications you requested, Sir. LoL

Code:

window.onload=function (){
 findAllLinks()
 replaceImgPaths()
}

function findAllLinks(){
	var exclude=["domainA.com","domainB.com"] // This is the array you modify

	var excludeRegExp=new RegExp(exclude.join("|"),"i") // This generates a regular expression based on the excluded domains.
	var links=document.getElementsByTagName('a')  // Get all the links
	for(var link=0;link<links.length;link++){
		if(!excludeRegExp.test(links[link])){ // If none of the domains in the RegExp exists in the URL, modify the link.
			links[link].onclick="window.open(\"http://url.w2n.net/*"+links[link].href+"\")"  // Prepend the clicktracker.
		}
	}
}

It now has a normal href attribute, so if the visitor right-clicks and opens it in a new window manually, it'll still work but you don't get the click tracked.

[TwoD]

Yes, it might work if placed at the end of the document, but placing it in the header and running it onload would be the way most people would do it, and it doesn't clutter up the body contents that way.
But why is it so important that it doesn't run onload?

Yes, I alread know the code isn't working! There is something which keeps the onclick from firing at all, I don't know what yet. I thought it was working when I tested it because it popped up in a new window like it should. I didn't notice the base target tag and I was writing that response while you posted yours, so I didn't know it wasn't working at that time.

For some **** reason it won't run the code at all when it's put in as a string, I have to create a costom function instead...

Code:

var exclude=["w2n.net", "w2hub.com"] // This is the array you modify
var excludeRegExp=new RegExp(exclude.join("|"),"i") // This generates a regular expression based on the excluded domains.
var links=document.getElementsByTagName('a')  // Get all the links
for(var link=0;link<links.length;link++){
	if(!excludeRegExp.test(links[link])){ // If none of the domains in the RegExp exists in the URL, modify the link.
		links[link].onclick=new Function("window.open('http://url.w2n.net/*"+links[link].href+"');return false")
	}
}

[w2n]

Hi again,

I have tested it and it IS working perfectly, as it should!

Many many thanks for the code!

:-)