[imparator]

Hi guys, I'm having some trouble validating Australian phone numbers (both land line and Mobile)

I'm using to following reg expression which i got from:http://regexlib.com/REDetails.aspx?regexp_id=1248

Code:

^[0-9]{10}$|^\(0[1-9]{1}\)[0-9]{8}$|^[0-9]{8}$|^[0-9]{4}[ ][0-9]{3}[ ][0-9]{3}$|^\(0[1-9]{1}\)[ ][0-9]{4}[ ][0-9]{4}$|^[0-9]{4}[ ][0-9]{4}$

But when I open the JavaScript Console in Firefox i get:

Error: syntax error
Line: 31, Column: 56

As I'm using an external file i've posted the contents below:

Code:

function validate_form ( )
{
	valid = true;
	

        	if ( document.contact.first_name.value == "" )
        	{
                alert ( "Please fill in the 'First Name' box." );
                valid = false;
        	}
			
			if ( document.contact.sur_name.value == "" )
        	{
                alert ( "Please fill in the 'Surname' box." );
                valid = false;
        	}

			if ( document.contact.address.value == "" )
        	{
                alert ( "Please fill in the 'Address' box." );
                valid = false;
        	}

			if ( document.contact.phone_number.value == "" )
        	{
                alert ( "Please fill in the 'Phone Number' box." );
                valid = false;
        	}

			
			else if ( document.contact.phone_number.value.search(^[0-9]{10}$|^\(0[1-9]{1}\)[0-9]{8}$|^[0-9]{8}$|^[0-9]{4}[ ][0-9]{3}[ ][0-9]{3}$|^\(0[1-9]{1}\)[ ][0-9]{4}[ ][0-9]{4}$|^[0-9]{4}[ ][0-9]{4}$) ==-1)
        	{
                alert ( "Phone Number is in an invalid format." );
                valid = false;
        	}

			
			if ( document.contact.email.value == "" )
        	{
                alert ( "Please fill in the 'Email' box." );
                valid = false;
        	}
			
			
			else if ( document.contact.email.value.search(/^[a-zA-Z][\w\.-]*[a-zA-Z0-9]@[a-zA-Z0-9][\w\.-]*[a-zA-Z0-9]\.[a-zA-Z][a-zA-Z\.]*[a-zA-Z]$/) ==-1)
        	{
                alert ( "Email is in an invalid format." );
                valid = false;
        	}




return valid; 
}

I'm new to JavaScript so any help you provide would be much appreciated

Thankyou in advance.

[TwoD]

You must put // around the RegExp or JS will try to interpret it as a variable or number.

Code:

else if ( document.contact.phone_number.value.search(/^[0-9]{10}$|^\(0[1-9]{1}\)[0-9]{8}$|^[0-9]{8}$|^[0-9]{4}[ ][0-9]{3}[ ][0-9]{3}$|^\(0[1-9]{1}\)[ ][0-9]{4}[ ][0-9]{4}$|^[0-9]{4}[ ][0-9]{4}$/) ==-1)

You can also remove the

Code:

			if ( document.contact.phone_number.value == "" )
        	{
                alert ( "Please fill in the 'Phone Number' box." );
                valid = false;
        	}

			
			else

part above it since the RegExp will not match if the string is empty, so the previous test is unneccessary.

[imparator]

that fixed it, thank you very much