Incrementing a PHP loop with JS

MesaFloyd · #1 (**permalink**) 04-11-10, 09:39 AM

I am an <older> rookie, please be gentle with me.
I make a table called from a DB using PHP
The table loops the DB untill all the occupied fields are displayed - works fine -
I am trying to insert a button for each row (JS), that when pressed will highlight and copy to clipboard one particular cell of that row
The button is not working properly. When I press any of the buttons on the table, only the first cell is higlighted and copied.
I know it is because all the buttons are calling the same cell, but I don't know how to make the button increment for each row.
Any of you programming gru's able to help me?. - yes, I know this will only work in IE -
I think the solution is in JS, but I am not sure if it can be fixed in PHP.
Please keep it simple for me.
Thanks in advance -
Floyd
Here's my code (i know is it not perfect, but neigher am I)

Code:

<script language='Javascript'>
	function doact(d)
	{
	var doc = eval("document.readme."+d);
	cp = doc.createTextRange();
	doc.focus();
	doc.select();
	cp.execCommand("Copy");
	}
</script>

<form name="readme">
<?php
	include("database.php");
	$query = "SELECT * FROM users"; 
	$result = mysql_query($query) or die(mysql_error());

		echo "<table border='1'>";
		echo "<tr> <th>Username</th> <th>IP Address</th><th>Email Address</th> <th>Last Visit Date-Time </th></tr>";

	// keeps getting the next row until there are no more to get
		while($row = mysql_fetch_array( $result ))
	{
		// Print out the contents of each row into a table
		echo "<tr><td>";
		echo $row['username'];
		echo "</td><td>";
?>
	<TEXTAREA name="text1" style="width: 150px; height: 20px;" >
<?php 
		echo $row['pcidip']; 	
?>
	</TEXTAREA>
		<input onclick="doact('text1')" type="button" value="Copy IP">
</form>
<?php		
		echo "</td><td>";
		echo $row['email'];
		echo "</td><td>";
		echo $row['datetime'];
		echo "</td></tr>"; 
	}
		echo "</table>";
?>

wirehopper · #2 (**permalink**) 04-11-10, 10:35 AM

Add a counter (I used $i). Initialize it to zero before the while loop.

Change the button code like so:

<input onclick="doact('text<?php echo $i++; ?>')" type="button" value="Copy IP">

What it should do is increment the counter (so the first button refers to text1), then add the 1 to 'text' - so you get doact('text1') for the first row, doact('text2') for the second row, etc.

I'm not perfect either - this code and idea hasn't been tested, but I hope it helps you.

MesaFloyd · #3 (**permalink**) 04-11-10, 10:57 AM

Thanks wirehopper
I have two references to text1
I replaced my references from
text1
to
text<?php echo $i++; ?>

At the bottom on the web page, when a button is pushed I see
!Error on page.

you can see the results here
viewdatabase-testbutton-help.php

before the change to the above there was no error like stated earlier, any button would only highlight and copy the first IP address...

You mentioned " Initialize it to zero before the while loop"
am I suppose to add code to initialize it to zero, or does it do that by itself?

Floyd

wirehopper · #4 (**permalink**) 04-11-10, 03:10 PM

To initialize it to zero:

$i=0;
while (remainder of your code here)

job0107 · #5 (**permalink**) 04-11-10, 11:11 PM

Your incrementing $i for each reference (once for the textarea and once for the button) and they are not lining up, so none of your buttons work.

Try it like this:

PHP Code:


			
<html>
<head>
<script>
    function doact(d)
    {
    var doc = eval("document.readme."+d);
    cp = doc.createTextRange();
    doc.focus();
    doc.select();
    cp.execCommand("Copy");
    }
</script>
</head>
<body>
<?php
   $i=0;
    include "database.php";
    $query = "SELECT * FROM users";
    $result = mysql_query($query) or die(mysql_error());
   echo "<form name='readme'><table border='1'><tr> <th>Username</th> <th>IP Address</th><th>Email Address</th> <th>Last Visit Date-Time </th></tr>";
    // keeps getting the next row until there are no more to get
    while($row = mysql_fetch_assoc( $result ))
    {
     // Print out the contents of each row into a table
     echo "<tr><td>".$row['username']."</td>
           <td><TEXTAREA name='text$i' style='width: 150px; height: 20px;'>".$row['pcidip']."</TEXTAREA>
                <input onclick=\"doact('text$i')\" type='button' value='Copy IP'></td>
           <td>".$row['email']."</td>
           <td>".$row['datetime']."</td>
          </tr>";
    $i++;
    }
        echo "</table></form>";
?>
</body>
</html>

MesaFloyd · #6 (**permalink**) 04-12-10, 12:27 AM

********SOLVED****************
Mr. Broughton, thank you so much.
Absolutly perfect!!!
Works just as I trying.
It is nice to receive such professional level help
I will study your changes to help me in the future
Deep appreciation..
Floyd

job0107 · #7 (**permalink**) 04-12-10, 07:39 AM

Your welcome.

barbarahelen · #8 (**permalink**) 05-05-10, 10:49 PM

It should be $counter otherwise PHP will see it always as 0 and not changing, therefore it will always be smaller than $endNum, therefore the condition will never be satisfied thus the loop never ends!
Alpine White Teeth

job0107 · #9 (**permalink**) 05-06-10, 08:50 AM

Quote:

Originally Posted by barbarahelen

It should be $counter otherwise PHP will see it always as 0 and not changing, therefore it will always be smaller than $endNum, therefore the condition will never be satisfied thus the loop never ends!
Alpine White Teeth

barbarahelen,
What are you talking about?
Where do you see $counter and $endNum?

edwardbrian · #10 (**permalink**) 05-08-10, 05:38 AM

Try these solutions. Open your browser, click the menu button, scroll to Options. Go into Browser Configuration and check "Support JavaScript".

Acai Complete 6