[AhmedX]

i wrote this code that resize the hight and width of an image but i am facing a problem the code i wrote is made of two function i want to run only one function at time want to add an if statment to check the hight and width are more than the max hight and width and for the function i want to add else if statment to check if the hight and width are less than the max hight and width i tried evreything i could think of but there was no hope where i am going wrong

here is my code java script

Code:

<script type="text/javascript">
var w=document.getElementById("h1").getAttribute("width");
var h=document.getElementById("h1").getAttribute("height");
var smallImage
var BigImage
if(w<217&&h<192){
smallImage=function resizesSmallImage(){//do the function on load
var w=document.getElementById("h1").getAttribute("width");

var h=document.getElementById("h1").getAttribute("height");

var maxheight=192;
var maxwidth=217;
var diffrance;
var i;
if(w>h){
diffrance=maxwidth-w;//197
for(i=w;i<diffrance;i++){
    w++;
    h++;
    if(h==maxheight||w==maxwidth){break;}
}
w=document.getElementById("h1").setAttribute("width",w)
h=document.getElementById("h1").setAttribute("height",h)
}// compare number of the same amount of digits ex:10 with 200
else if(w<h){
    diffrance=maxheight-h;//204
for(i=h;i<diffrance;i++){
    w++;
    h++;
    if(h==maxheight||w==maxwidth){break;}
}
w=document.getElementById("h1").setAttribute("width",w)
h=document.getElementById("h1").setAttribute("height",h)
}

else{    
for(i=h;i<maxheight;i++){
    w++;
    h++;
if(h==maxheight||w==maxwidth){break;}
}
w=document.getElementById("h1").setAttribute("width",w)
h=document.getElementById("h1").setAttribute("height",h)
}

}//end function
window.onload=smallImage
}//end SMALL if

else if(w>217&&h>192){
BigImage=function resizesBigImage(){
var w=document.getElementById("h1").getAttribute("width");
var h=document.getElementById("h1").getAttribute("height");

var maxheight=192;
var maxwidth=217;
var diffrance;
var i;
if(w>h){
diffrance=w-maxwidth;//600
for(i=w;i>maxwidth;i--){
    w--;
    h--;
if(h==maxheight||w==maxwidth){break;}
}
w=document.getElementById("h1").setAttribute("width",w)
h=document.getElementById("h1").setAttribute("height",h)
}// compare number of the same amount of digits ex:10 with 200
else if(w<h){
    diffrance=h-maxheight;//500
for(i=h;i>maxheight;i--){
    w--;
    h--;
if(h==maxheight||w==maxwidth){break;}
}//end for
w=document.getElementById("h1").setAttribute("width",w)
h=document.getElementById("h1").setAttribute("height",h)
}//end else if

else{
    for(i=h;i>maxheight;i--){
    w--;
    h--;
if(h==maxheight||w==maxwidth){break;}
}
w=document.getElementById("h1").setAttribute("width",w)
h=document.getElementById("h1").setAttribute("height",h)
}

}//end function
window.onload=BigImage
}
</script>

here is my HTML

HTML Code:

<img src="images.jpeg" id="h1"  width="50" height="70" />

[DLJ]

What is it exactly that you want? Using a text box to change the width and height or...?

Instead of

Code:

w=document.getElementById("h1").setAttribute("width",w);
h=document.getElementById("h1").setAttribute("height",h);

Try this

Code:

w=document.getElementById("h1").width="";
h=document.getElementById("h1").height="";

Also, check your code for missing semicolons. I just glanced through, but I saw at least four lines missing them. Specifically, the lines containing

Code:

document.getElementById("h1").setAttribute("width",w)

Hope this helps!