[PHP Warner]

Hello,

I want to empty selected folder and then remove it.

My code is below:

delete.cgi

Code:

#!/usr/bin/perl
use CGI;
use CGI qw/:standard/;
use Config;
my $cg = new CGI;
my $ID_IDENTIFIER = $cg->param('ID_IDENTIFIER');
#my $FILE_IDENTIFIER = $cg->param('FILE_IDENTIFIER');

my $target_dir = "$c->{target_dir}/$ID_IDENTIFIER";
#my $target_file = "$c->{target_dir}/$ID_IDENTIFIER/$FILE_IDENTIFIER";

&DelData($target_dir);

sub DelData
{
   my ($dir) = @_;
   opendir(DIR, $dir) || die"Hata";
   my @ff = readdir(DIR);
   closedir(DIR);
   for my $fn(@ff)
   {
      unlink("$dir/$fn");
      print("$dir/$fn has been empty");
   }
   rmdir("$dir");
   print("$dir has been deleted");
}

Config.pm

Code:

package Config;

BEGIN
{
use Exporter;
@Config::ISA = qw( Exporter );
@Config::EXPORT = qw( $c );
}

our $c=
{
target_dir => '/usr/home/site/public_html/target',
};
1;

Always giving Internal Server Error. Target dir chmod is 777 and no problem with user groups. Also script chmod is 755.

perl -cw delete.cgi
Syntax OK

How can I fix this, any ideas?

Thanks now.

[Millennium]

adding this line to the main script:

Code:

use CGI::Carp qw/fatalsToBrowser/;

will redirect most fatal errors to the browser. It's helpfule for debugging scripts.

It looks to me like the first problem and maybe the only problem, is that you have not printed a header before trying to print some data to the browser, change this:

Code:

my $cg = new CGI;
my $ID_IDENTIFIER = $cg->param('ID_IDENTIFIER');

to:

Code:

my $cg = new CGI;
print $cg->header;
my $ID_IDENTIFIER = $cg->param('ID_IDENTIFIER');

and hopefully all will be well.

[Millennium]

here's a suggestion for your script:

Code:

#!/usr/bin/perl
use CGI;
use Config;
use File::Path;
my $cg = new CGI;
print $cg->header,$cg->start_html;
my $ID_IDENTIFIER = $cg->param('ID_IDENTIFIER');
#my $FILE_IDENTIFIER = $cg->param('FILE_IDENTIFIER');
my $target_dir = "$c->{target_dir}/$ID_IDENTIFIER";
#my $target_file = "$c->{target_dir}/$ID_IDENTIFIER/$FILE_IDENTIFIER";

rmtree($target_dir, 1, 1);

print $cg->end_html;

see the File:ath module:

http://perldoc.perl.org/File/Path.html

also, passing a filename as a CGI parameter to the script and not doing any validation/taint checking is insecure. If you are the only person with access to the script then I assume you know what you are doing. If this script will be used by the public you will want to do some validation and taint checking on any variables used for possible insecure operations, such as deleting files/directories. Read up here if interested:

http://users.easystreet.com/ovid/cgi...son_three.html

[PHP Warner]

Hello ,

I have try to use rmtree but it doesn't work. I added print $cg->header; it works perfect. And also use CGI::Carp qw/fatalsToBrowser/; showed the error on opendir(DIR, $dir)

So I have changed my codes like this:

Code:

#!/usr/bin/perl
use CGI;
use Config;
use File::Path;
my $cg = new CGI;
print $cg->header,$cg->start_html;
my $ID_IDENTIFIER = $cg->param('ID_IDENTIFIER');
my $FILE_IDENTIFIER = $cg->param('FILE_IDENTIFIER');

my $target_dir = "$c->{target_dir}/$ID_IDENTIFIER";
my $target_file = "$c->{target_dir}/$ID_IDENTIFIER/$FILE_IDENTIFIER";

unlink("$target_file");
rmdir("$target_dir");

print("$target_file has been deleted<br>$target_dir removed");

print $cg->end_html;

This works fine. Thank you sooooo much : ).

[Millennium]

You're welcome.

If rmtree() doesn't work then you don't need to load the File:ath module