[sujata_ghosh]

Hi to all!

a CGI script is takeing data from a Form and sending email using that the form message text box containing this:

Code:

Dear Sir/Madam,
After a long time we have come out with a new edition of While You were Trading which is attached along with this mail. You can also view it here http://www.k****ij.com/research/whil...ng/index.shtml
To take a look at how Asian Currencies are expected to perform in the forcible future click here http://www.k****ij.com/research/usdkrw.shtml
To download the PDF version of the report you can click here
http://www.k****ij.com/research/Asian Currencies June07.pdf

the last URL is like that: http://www.k****ij.com/research/Asian Currencies June07.pdf

which whole part is not beging linkable on text or HTML email.

i have set the varaiable for HTML mail as follows:

$message = $INPUT{'message'};
$messtext = $INPUT{'message'};

($messhtml = $message) =~ s/(\w+\@\w+\.\w+)/<a href=\"<A href="mailto:$1\">$1<\/a>/g">mailto:$1\">$1<\/a>/g;
$messhtml =~ s/(\w+:\/\/)([.a-zA-Z0-9\-~\/\_\/\?\/\=\/]*)/<a href=\"$1$2\">$1$2<\/a>/g;

$messtext is for text mail and $messhtml for HTML email i am using but that space is not converted properly and only this part 'http://www.k****ij.com/research/Asian' is clickable rest 'Currencies June07.pdf' is not.

please help me out!

[curbview.com]

Originally Posted by sujata_ghosh

Hi to all!

a CGI script is takeing data from a Form and sending email using that the form message text box containing this:

Code:

Dear Sir/Madam,
After a long time we have come out with a new edition of While You were Trading which is attached along with this mail. You can also view it here http://www.k****ij.com/research/whil...ng/index.shtml
To take a look at how Asian Currencies are expected to perform in the forcible future click here http://www.k****ij.com/research/usdkrw.shtml
To download the PDF version of the report you can click here
http://www.k****ij.com/research/Asian Currencies June07.pdf

the last URL is like that: http://www.k****ij.com/research/Asian Currencies June07.pdf

which whole part is not beging linkable on text or HTML email.

i have set the varaiable for HTML mail as follows:

$message = $INPUT{'message'};
$messtext = $INPUT{'message'};

($messhtml = $message) =~ s/(\w+\@\w+\.\w+)/<a href=\"<A href="mailto:$1\">$1<\/a>/g">mailto:$1\">$1<\/a>/g;
$messhtml =~ s/(\w+:\/\/)([.a-zA-Z0-9\-~\/\_\/\?\/\=\/]*)/<a href=\"$1$2\">$1$2<\/a>/g;

$messtext is for text mail and $messhtml for HTML email i am using but that space is not converted properly and only this part 'http://www.k****ij.com/research/Asian' is clickable rest 'Currencies June07.pdf' is not.

please help me out!

Your regex is too greedy. Check you mail / PM box for a solution.

[Drunken Perl Coder]

You have spaces in a filename/URL? That in itself is not a good idea. Rename the file:

Asian_Currencies_June07.pdf

and it should work.

[curbview.com]

Besides the regex I sent you, you would want to scrub your user input from rogue visitors. The spaces in the URL are not really spaces...Line breaks and or high ASCII valued characters will ruin your regex.

[UnrealEd]

Originally Posted by curbview.com

Your regex is too greedy. Check you mail / PM box for a solution.

That's not how it works on this forum
If you want to help people, post your solutions in the topic, so other people can anticipate on your solution.

[sujata_ghosh]

Thanks guys for your help!

that means if my url have any space it won't work?? why?

if we write some url with space it converted the space into '20%'

i don;t know how to track space using regex.

can't i do that at here? instead of do that "Asian_Currencies_June07.pdf"???

see its not user input its file which we are sending to client insteade of attachemnet to download it. we have used it on site also. so that means we need to make each file with types to use it on email and one on website!!!!!

[curbview.com]

Originally Posted by UnrealEd

That's not how it works on this forum
If you want to help people, post your solutions in the topic, so other people can anticipate on your solution.

I would post code here on the forum, BUT the only tag I see to wrap code in is PHP I don't see one to wrap/format Perl code. Perhaps that is a suggestion/ability worth adding to the forum?

[Drunken Perl Coder]

Originally Posted by sujata_ghosh

Thanks guys for your help!

that means if my url have any space it won't work?? why?

if we write some url with space it converted the space into '20%'

i don;t know how to track space using regex.

can't i do that at here? instead of do that "Asian_Currencies_June07.pdf"???

see its not user input its file which we are sending to client insteade of attachemnet to download it. we have used it on site also. so that means we need to make each file with types to use it on email and one on website!!!!!

Why can't you just properly rename the file to Asian_Currencies_June07.pdf? Spaces in filenames is OK on your local windows PC but you should not use them for files you post on the internet.

[Drunken Perl Coder]

Try this, might need tweaking but that's up to you to figure out:

Code:

$messhtml = q~Dear Sir/Madam,
After a long time we have come out with a new edition of While You were Trading which is attached along with this mail. You can also view it here http://www.example.com/research/whilng/index.shtml
To take a look at how Asian Currencies are expected to perform in the forcible future click here http://www.example.com/research/usdkrw.shtml
To download the PDF version of the report you can click here
http://www.example.com/research/Asian Currencies June07.pdf~;

$messhtml =~ s#(http://[.\w/]+/(?:\w+\s*\w+)+\.\w{3,5}\b)#<a href="$1">$1</a>#sg;

print $messhtml;

[Christian]

Originally Posted by curbview.com

Perhaps that is a suggestion/ability worth adding to the forum?

[highlight=perl][/highlight] OR [code][/code]