Whats going wrong here?

Tyreal · #1 (**permalink**) 06-23-04, 05:59 AM

We have a script that soeone else wrote and ive been asked to amend it to display something queried froma database

however im totally new to php and its just totally over my head :/

heres the script:

<HTML>
<HEAD>
<TITLE>Time Sheet Analysis - Menu -</TITLE>
</HEAD>
<BODY><BR>
<CENTER><h2>
<?PHP
// Connect information.
include("dataconnect.inc");

// get username from cookie
$username = $_COOKIE['username'];
$userid = @current(mysql_fetch_row(mysql_query("SELECT userid FROM users WHERE username = '$username'")));

// DB connection.
mysql_connect($host, $user, $pwd) || die (mysql_error());
mysql_select_db($dbase);

//query database for fullname
$fullname = @current(mysql_fetch_row(mysql_query("SELECT fullname FROM users WHERE username = '$username'")));

print("$fullname");

?>
</h2></CENTER>
<BR>
<H2><CENTER><U>Please select option</U></CENTER></H2>
<BR><BR>
<CENTER><A HREF="chkjobstatus.php"> NEW JOB</A></CENTER><BR>
<CENTER><A HREF="chkjobstatusclose.php"> CLOSE JOB</A></CENTER><BR>
<CENTER><A HREF="showcurrent.php"> SHOW CURRENT JOB</A></CENTER><BR>
<center>

<?php
//Get todays job
$todaysdate = date("Y-m-d");

//Select all data concerning jobs for the day
$showqry = "SELECT distinct job, starttime, endtime, cadnum, cadprefixname
FROM jobstatus, time, job, cads, cadprefix
WHERE job.jobstatid = jobstatus.jobstatid
AND job.timeid = time.timeid
AND cads.cadprefixid = cadprefix.cadprefixid
AND cads.cadid = job.cadid
AND userid = '$userid' AND jobdate = '$todaysdate' ORDER BY starttime DESC";

$showrlt = mysql_query($showqry);

print($showrlt)
?>

</center><br>
<CENTER><A HREF="http://cgi.economatics.force9.co.uk/php/timesheet/index.php"> EXIT</A></CENTER><BR>
<BR>

</BODY>
</HTML>

the 2nd part of the script with the php in is the part thats not working eevn with the dbase connection addded in

just comes up with resource id #5

any help for a n00b please

<?Wille?> · #2 (**permalink**) 06-23-04, 08:11 AM

im not sure about that || in connection.. but the problem is that you cant echo (or print) the query..
change the print to this and you should get otherkind of output

PHP Code:


			
while ($r = mysql_fetch_array($showrlt)) {

$disc = $r['distinct job']; // it would be wise to use htmlspecialchars($r['distinct job'])

$start = $r['starttime'];

$end = $r['endtime'];

$cadn = $r['cadnum'];

$cadpre = $r['cadprefixname'];

echo($start." ".$end." ".$cadn." ".$cadpre."<br>");

Tyreal · #3 (**permalink**) 06-24-04, 03:10 AM

well the first part of the php works fine its the second part that doesnt ill give it a try thanks

blaw · #4 (**permalink**) 06-26-04, 01:44 AM

Hello,

This part of your script:

PHP Code:


			
 $showrlt = mysql_query($showqry);



print($showrlt)

mysql_query(), when used for an SQL statement that returns rows, will return the resouce, and this is not something you can just echo/print, because there could be more than one rows/fields returned, and you want to modify/layout them most likely.

You can use mysql_fetch_array(), mysql_fetch_row(), or mysql_fetch_assoc() to get the resource (results of the query) into an array row by row. After that, you can echo each value according to your needs. For more info about those functions, the very best place with examples would be here:

http://ca2.php.net/mysql-fetch-array
http://ca2.php.net/mysql-fetch-row
http://ca2.php.net/mysql-fetch-assoc

Good luck then!

Tyreal · #5 (**permalink**) 06-28-04, 05:05 AM

hehe i will try thankyou, ima total noob dropped in at the deep end so....

i will try and sort it, as all it does is bring a row back sooo

thanks for the help