using ?id=$id from a mysql table in php

kasper · #1 (**permalink**) 06-29-04, 05:32 PM

Hey guys, I have a page that is loaded using php/mysql displays the results into a table, i have added an extra column for a "up date / change" option.

how do I use the ?id=$id for a link, for each individual row (person), something like my website/update.php?id=$id where $id would be the persons id from my DB.. code as follows:

<?
include("dbinfo.inc.php");
mysql_connect(localhost,$username,$password);
@mysql_select_db($database) or die( "Unable to select database");
$query="SELECT * FROM EmpInfo";
$result=mysql_query($query);

$num=mysql_numrows($result);

mysql_close();

echo "<b><center>Employee Database</center></b><br><br>";

?><body background="back.gif">
<table border="1" cellspacing="2" cellpadding="2">
<tr>
<th><font face="Arial, Helvetica, sans-serif">Employee</font></th>
<th><font face="Arial, Helvetica, sans-serif">EmployeeID</font></th>
<th><font face="Arial, Helvetica, sans-serif">CrewID</font></th>
<th><font face="Arial, Helvetica, sans-serif">Update / Delete</font></th>
</tr>

<?
$i=0;
while ($i < $num) {
$Employee=mysql_result($result,$i,"Employee");
$EmployeeID=mysql_result($result,$i,"EmployeeID");
$CrewID=mysql_result($result,$i,"CrewID");
?>

<tr>
<td><font face="Arial, Helvetica, sans-serif"><? echo "$Employee"; ?></font></td>
<td><font face="Arial, Helvetica, sans-serif"><? echo "$EmployeeID"; ?></font></td>
<td><font face="Arial, Helvetica, sans-serif"><? echo "$CrewID"; ?></font></td>
<td><font face="Arial, Helvetica, sans-serif"><a href="update.php?id=$id">Update</a></font></td>
</tr>
<?
++$i;
}
echo "</table>";

?>

nekeno12 · #2 (**permalink**) 06-29-04, 05:52 PM

"><a href="update.php?id=$_GET[id]">

kasper · #3 (**permalink**) 06-29-04, 06:12 PM

tried that, but it just comes back with a blank page. ?

do i hav eto call it with an <? echo or similar?

thankx

nekeno12 · #4 (**permalink**) 06-29-04, 06:30 PM

Yup,

Try a href="update.php?id=<? echo("$_GET[id]"); ?>">Update</a>

kasper · #5 (**permalink**) 06-29-04, 06:52 PM

I'm missing someing here still,, it's link is showing "update.php?ID="

it's not getting the ID... am I missing a call? like ... a WHERE ID=$ID or something?
and if so where would I put it?

thankx

infinitylimit · #6 (**permalink**) 06-29-04, 07:53 PM

First of all the code you supplied doesn't have an $id defined so that is why you are having a problem. I'm assuming you want to use the primary key of the table and that primary key is EmployeeID. Below is the code that will work.

PHP Code:


			
<a href="update.php?id=<?php echo $EmployeeID; ?>">Update</a>

update.php will need to do a $_GET['id'] to be able to find the information needed.

I also noticed that you are using a wildcard SQL statement. If you plan on using this a lot you might want to do something like SELECT employeeID,CrewID, ... ect instead of *

You might also peek at http://us2.php.net/mysql_result for information regarding it's use on large sets of data.

Hope this helps,
-IL

kasper · #7 (**permalink**) 06-30-04, 08:56 AM

still missing something (i'm an idiot

)
when usuing what u suggested, the link is right with the update.php?id=employee id here. but when clicked it looks to me like its still trying to use the ID instead.... primary key is ID with autoinc and now EmployeeID.

employee.php:
*********
<?
include("dbinfo.inc.php");
mysql_connect(localhost,$username,$password);
@mysql_select_db($database) or die( "Unable to select database");
$query="SELECT Employee,EmployeeID,CrewID FROM EmpInfo";
$result=mysql_query($query);

$num=mysql_numrows($result);

mysql_close();

echo "<b><center>Employee Database</center></b><br><br>";

?><body background="arb.gif">
<table border="1" cellspacing="2" cellpadding="2">
<tr>
<th><font face="Arial, Helvetica, sans-serif">Employee</font></th>
<th><font face="Arial, Helvetica, sans-serif">EmployeeID</font></th>
<th><font face="Arial, Helvetica, sans-serif">CrewID</font></th>
<th><font face="Arial, Helvetica, sans-serif">Update</font></th>
<th><font face="Arial, Helvetica, sans-serif">Delete</font></th>
</tr>

<?
$i=0;
while ($i < $num) {
$Employee=mysql_result($result,$i,"Employee");
$EmployeeID=mysql_result($result,$i,"EmployeeID");
$CrewID=mysql_result($result,$i,"CrewID");
?>

<tr>
<td><font face="Arial, Helvetica, sans-serif"><? echo "$Employee"; ?></font></td>
<td><font face="Arial, Helvetica, sans-serif"><? echo "$EmployeeID"; ?></font></td>
<td><font face="Arial, Helvetica, sans-serif"><? echo "$CrewID"; ?></font></td>
<td><font face="Arial, Helvetica, sans-serif"><a href="update.php?ID=<?php echo $EmployeeID; ?>">Update</a></font></td>
<td><font face="Arial, Helvetica, sans-serif"><a href="delete.php?ID=<?php echo $EmployeeID; ?>">Delete</a></font></td>
</tr>
<?
++$i;
}
echo "</table>";

?>

**************
update.php
**************
<?
include("dbinfo.inc.php");
$ID=$_GET['ID'];
mysql_connect(localhost,$username,$password);
@mysql_select_db($database) or die( "Unable to select database");
$query="SELECT Employee,EmployeeID,CrewID FROM EmpInfo WHERE ID='$ID'";
$result=mysql_query($query);
$num=mysql_numrows($result);
mysql_close();

$i=0;
while ($i < $num) {
$Employee=mysql_result($result,$i,"Employee");
$EmployeeID=mysql_result($result,$i,"EmployeeID");
$CrewID=mysql_result($result,$i,"CrewID");

?>

<form action="updated.php" method="post">
<input type="hidden" name="ud_ID" value="<? echo "$ID"; ?>">
Employee: <input type="text" name="ud_Employee" value="<? echo "$Employee"?>"><br>
Employee ID: <input type="text" name="ud_EmployeeID" value="<? echo "$EmployeeID"?>"><br>
Crew ID: <input type="text" name="ud_CrewID" value="<? echo "$CrewID"?>"><br>
<input type="Submit" value="Update">
</form>

<?
++$i;
}
?>

mikaelf · #8 (**permalink**) 06-30-04, 10:30 AM

May be I can give little help here...

Quote:

Originally Posted by kasper

still missing something (i'm an idiot

)
when usuing what u suggested, the link is right with the update.php?id=employee id here. but when clicked it looks to me like its still trying to use the ID instead.... primary key is ID with autoinc and now EmployeeID.

employee.php:
*********
<?
include("dbinfo.inc.php");
mysql_connect(localhost,$username,$password);
@mysql_select_db($database) or die( "Unable to select database");
$query="SELECT Employee,EmployeeID,CrewID FROM EmpInfo";
$result=mysql_query($query);

$num=mysql_numrows($result);

mysql_close();

echo "<b><center>Employee Database</center></b><br><br>";

?><body background="arb.gif">
<table border="1" cellspacing="2" cellpadding="2">
<tr>
<th><font face="Arial, Helvetica, sans-serif">Employee</font></th>
<th><font face="Arial, Helvetica, sans-serif">EmployeeID</font></th>
<th><font face="Arial, Helvetica, sans-serif">CrewID</font></th>
<th><font face="Arial, Helvetica, sans-serif">Update</font></th>
<th><font face="Arial, Helvetica, sans-serif">Delete</font></th>
</tr>

<?
$i=0;
while ($i < $num) {
$Employee=mysql_result($result,$i,"Employee");
$EmployeeID=mysql_result($result,$i,"EmployeeID");
$CrewID=mysql_result($result,$i,"CrewID");
?>

<tr>
<td><font face="Arial, Helvetica, sans-serif"><? echo "$Employee"; ?></font></td>
<td><font face="Arial, Helvetica, sans-serif"><? echo "$EmployeeID"; ?></font></td>
<td><font face="Arial, Helvetica, sans-serif"><? echo "$CrewID"; ?></font></td>
<td><font face="Arial, Helvetica, sans-serif"><a href="update.php?ID=<?php echo $EmployeeID; ?>">Update</a></font></td>
<td><font face="Arial, Helvetica, sans-serif"><a href="delete.php?ID=<?php echo $EmployeeID; ?>">Delete</a></font></td>
</tr>
<?
++$i;
}
echo "</table>";

?>

**************
update.php
**************
<?
include("dbinfo.inc.php");
$ID=$_GET['ID'];
mysql_connect(localhost,$username,$password);
@mysql_select_db($database) or die( "Unable to select database");
$query="SELECT Employee,EmployeeID,CrewID FROM EmpInfo WHERE ID='$ID'";
$result=mysql_query($query);
$num=mysql_numrows($result);
mysql_close();

$i=0;
while ($i < $num) {
$Employee=mysql_result($result,$i,"Employee");
$EmployeeID=mysql_result($result,$i,"EmployeeID");
$CrewID=mysql_result($result,$i,"CrewID");

?>

<form action="updated.php" method="post">
<input type="hidden" name="ud_ID" value="<? echo "$ID"; ?>">
Employee: <input type="text" name="ud_Employee" value="<? echo "$Employee"?>"><br>
Employee ID: <input type="text" name="ud_EmployeeID" value="<? echo "$EmployeeID"?>"><br>
Crew ID: <input type="text" name="ud_CrewID" value="<? echo "$CrewID"?>"><br>
<input type="Submit" value="Update">
</form>

<?
++$i;
}
?>

Pay attention to the bolded text:
1.I believe that mysql_numrows is not a valid PHP-built-in function. it should be mysql_num_rows
2.the loop will never start because the condition is always false ($num = 0 while $i increases with step 1).

Solution:
Change mysql_numrows into mysql_num_rows

kasper · #9 (**permalink**) 06-30-04, 11:16 AM

same result,

it is using the link update.php?id=(employee's ID) but when the page comes up it actually brings up the autoic'd ID, so loading up someone with the EmployeeID of 230, actually brings up the record number 230.

infinitylimit · #10 (**permalink**) 06-30-04, 12:53 PM

I'm a little confused by your statment.... can you provide a dump of your sql table structure here and also your update code, and state what it's trying to do?

using ?id=$id from a mysql table in php

Internet Services

Website Development

Tech Hardware