[Andy1984]

hi guys, i found this neat little script to upload images but being a n00b and proud of it i dunno how to edit the code so i can upload diffrent image formats (jpeg,bmp) aswel as the one its currently set to (gif)

PHP Code:

<form name="form1" method="post" action="" enctype="multipart/form-data"> 

<input type="file" name="imagefile"> 



<input type="submit" name="Submit" value="Submit"> 



<? 

if(isset( $Submit )) 

{ 

//If the Submitbutton was pressed do: 



if ($_FILES['imagefile']['type'] == "image/gif") 

{ 



copy ($_FILES['imagefile']['tmp_name'], "tactic_img/".$_FILES['imagefile']['name']) 

or die ("Could not copy"); 



echo ""; 

echo "Name: ".$_FILES['imagefile']['name'].""; 

echo "Size: ".$_FILES['imagefile']['size'].""; 

echo "Type: ".$_FILES['imagefile']['type'].""; 

echo "Copy Done...."; 

} 



else { 

echo ""; 

echo "Could Not Copy, Wrong Filetype (".$_FILES['imagefile']['name'].")"; 

} 

} 



?> </form>

its for part of a tactics page for my clans members area
thanks
-Andy

[Bonzo]

I cant remember where in the php forum but there is a good example of an upload code for multiple files as well; it has an array defining the file types.

Look at NeverMinds script his as well as others use an array or list that would be easyer to modify I would have thought.

Anthony

[kvnband]

I'm thinking this might do the trick for ya

PHP Code:

<form name="form1" method="post" action="" enctype="multipart/form-data">

<input type="file" name="imagefile">



<input type="submit" name="Submit" value="Submit">



<?

if(isset( $Submit ))

{

//If the Submitbutton was pressed do:



if ($_FILES['imagefile']['type'] == "image/gif" || $_FILES['imagefile']['type'] == "image/jpeg" || $_FILES['imagefile']['type'] == "image/pjpeg" || $_FILES['imagefile']['type'] == "image/bmp")

{



copy ($_FILES['imagefile']['tmp_name'], "tactic_img/".$_FILES['imagefile']['name'])

or die ("Could not copy");



echo "";

echo "Name: ".$_FILES['imagefile']['name']."";

echo "Size: ".$_FILES['imagefile']['size']."";

echo "Type: ".$_FILES['imagefile']['type']."";

echo "Copy Done....";

}



else {

echo "";

echo "Could Not Copy, Wrong Filetype (".$_FILES['imagefile']['name'].")";

}

}



?> </form>

There, I THINK that should work

[Andy1984]

works perfectly, thanks kvnband

i had first tried that method before i came here after seeing similar code for diffrent formats but i had an error somewhere.

i see where i had gone wrong, thanks again

[infinitylimit]

I know you are using this on a clan site and probably won't expect hackers but that isn't the securest way to do file uploads. MIME types (ie image/jpeg) are pretty easily faked and you just do a straight copy of whatever is in the temp dir to your dir.

You might consider the following. snagged from http://us2.php.net/features.file-upload

PHP Code:

<?php

// In PHP versions earlier than 4.1.0, $HTTP_POST_FILES should be used instead

// of $_FILES.



$uploaddir = '/var/www/uploads/';

$uploadfile = $uploaddir . $_FILES['userfile']['name'];



print "<pre>";

if (move_uploaded_file($_FILES['userfile']['tmp_name'], $uploadfile)) {

   print "File is valid, and was successfully uploaded. ";

   print "Here's some more debugging info:\n";

   print_r($_FILES);

} else {

   print "Possible file upload attack!  Here's some debugging info:\n";

   print_r($_FILES);

}

print "</pre>";



?>