Can't see the error

fccolon · #1 (**permalink**) 07-13-04, 11:06 AM

Hi,

This is one of my first scripts and when I run it I get a parse error on line 9 - blowed if I can work it out at the moment.

Could someone point me to the error ?

<?php

$conn = mysql_connect(server, user, pwd);
echo $conn;
mysql_select_db("leaguedb", $conn);

$display_block = "<h1>Add Driver to Division</h1>

if ($_POST[op1] != "select1")

{

$get_list = "select id, div_name from GPL_division";
$get_list_res = mysql_query($get_list) or die(mysql_error());

$display_block .= "
<form method=\"post\" action=\"$_SERVER[PHP_SELF]\">
<p><strong> Select Division:</strong><br>
<select name=\"sel_id\">
<option value=\"\">-- Go on, pick your division --</option>";

while ($divrecs = mysql_fetch_array($get_list_res))
{
$id = $divrecs[id];
$div_name = stripslashes($divrecs[div_name]);
$display_block .= "
<option value=\"$id\">$div_name</option>";
}

$display_block .= "
</select>
<input type=\"hidden\" name=\"op1\" value=\"select1\">
<p><INPUT type=\"submit\" value=\"Select\"></p>

</form>";

}

if ($_POST[op2] != "select2")

{

$get_list = "select id, driver_name from GPL_drivers";
$get_list_res = mysql_query($get_list) or die(mysql_error());

$display_block .= "
<form method=\"post\" action=\"$_SERVER[PHP_SELF]\">
<p><strong> Select Drivers:</strong><br>
<select name=\"sel_id[]\" multiple>
<option value=\"\">-- Go on, pick your drivers --</option>";

while ($drvrecs = mysql_fetch_array($get_list_res))
{
$id = $drvrecs[id];
$driver_name = stripslashes($drvrecs[driver_name]);
$display_block .= "
<option value=\"$id\">$driver_name</option>";
}

$display_block .= "
</select>
<input type=\"hidden\" name=\"op2\" value=\"select2\">
<p><INPUT type=\"submit\" value=\"Select\"></p>

</form>";

}

if ($_POST[op1]= "select1")
if ($_POST[op2]= "select2")

{

$make_link = "INSERT INTO GPL_lsdd ('', '$divid', '$_POST[sel_id]')";

foreach ($_POST[sel_id] as $value)
{
echo $value;

$make_link_res = mysql_query($make_link) or die(mysql_error());

}

}

?>

<html>
<head>
<title>Add Drivers to Division</title>
</head>
<body>
<?php echo $display_block; ?>
</body>
</html>

Dj_Farout · #2 (**permalink**) 07-13-04, 12:15 PM

I think your problem is here... sometimes PHP will reject this because op1 isn't in quotes.. I know for a fact this wouldn't work in IIS

PHP Code:


			
 if ($_POST[op1] != "select1")

PHP Code:


			
if ($_POST["op1"] != "select1")

infinitylimit · #3 (**permalink**) 07-13-04, 02:21 PM

Dj_farout is incorrect your problem lies here

$display_block = "<h1>Add Driver to Division</h1>

you need a close quote and semicolon.
$display_block = "<h1>Add Driver to Division</h1>";

might I suggest using single quotes however unless you plan on putting in espace charaters.

Dj_Farout · #4 (**permalink**) 07-13-04, 02:40 PM

ya, your right.. I counted wrong.. I wish there was a way to put line numbers on there.. hehe

thanks for the backup, infinitylimit

fccolon · #5 (**permalink**) 07-14-04, 05:02 AM

D'oh.....

Thanks to you both for taking the time to have a look. I just need to sort my logic now

Whats the difference in using single/double quotes ?

fccolon · #6 (**permalink**) 07-15-04, 11:36 AM

The script executes now......only the db doesn't appear to get one of the values passed to it.

Whats supposed to happen is that you select a division from the first screen, that divisions id number is stored in var divid.
A list of drivers are then displayed, from which you can make multiple selections, which are stored in drv_id[].

The values from both sets of selection are to be stored in a table called GPL_lsdd, which has 3 fields for sid, divid, did - these relate to season, division & driver ids.
I'm passing a null for the first field at the mo.
Whats actually happening is that the table gets an entry like 0,0,3 or 0,0,4 so the divid var doesn't appear to be getting a value assigned to it.
I've tried moving the line that transfers the value from the selection around but with no luck.
Apologies for being a pain but could someone point to where I'm going wrong ?

Thanks in advance

fccolon · #7 (**permalink**) 07-16-04, 07:16 AM

I've put echos of the variables in at various points....and all is well with the $sel_divid var until I get inside the while statement....then nothing, tho echoing the $sel_drivid[] array works ok

???

mikaelf · #8 (**permalink**) 07-16-04, 01:28 PM

Quote:

Originally Posted by fccolon

I've put echos of the variables in at various points....and all is well with the $sel_divid var until I get inside the while statement....then nothing, tho echoing the $sel_drivid[] array works ok

???

Have you try to dump the variable (php function: var_dump or print_r). sometimes thehy will help a bit. sorry, i can't read the attachment. i have javascript disabled on my browser.

fccolon · #9 (**permalink**) 07-16-04, 02:54 PM

founds how yoy import the code now

PHP Code:


			


<?php



$conn = mysql_connect("server", "user", "pwd");

  

mysql_select_db("leaguedb", $conn);



if ($_POST[op1] != "select1")



 {



  $get_list = "select id, div_name from GPL_division";

  $get_list_res = mysql_query($get_list) or die(mysql_error());



  $display_block = "<h1>Add Driver to Division</h1>";



  $display_block .= "

       <form method=\"post\" action=\"$_SERVER[PHP_SELF]\">

       <p><strong> Select Division:</strong><br>

       <select name=\"sel_divid\">

       <option value=\"\">-- Go on, pick your division --</option>";



       while ($divrecs = mysql_fetch_array($get_list_res))

         {

          $id = $divrecs[id];

          $div_name = stripslashes($divrecs[div_name]);

          $display_block .= "

          <option value=\"$id\">$div_name</option>";

         }



   $display_block .= "

   </select>

   <input type=\"hidden\" name=\"op1\" value=\"select1\">

   <p><INPUT type=\"submit\" value=\"Select\"></p>



   </form>";





   $divid = $sel_divid;

  }



elseif ($_POST[op2] != "select2")



 {



echo $sel_divid;



  $get_list = "select id, driver_name from GPL_drivers";

  $get_list_res = mysql_query($get_list) or die(mysql_error());



  $display_block = "<h1>Add Driver to Division</h1>";

  $display_block .= "

       <form method=\"post\" action=\"$_SERVER[PHP_SELF]\">

       <p><strong> Select Drivers:</strong><br>

       <select name=\"sel_drvid[]\" multiple>

       <option value=\"\">-- Go on, pick your drivers --</option>";



       while ($drvrecs = mysql_fetch_array($get_list_res))

         {

          $id = $drvrecs[id];

          $driver_name = stripslashes($drvrecs[driver_name]);

          $display_block .= "

          <option value=\"$id\">$driver_name</option>";

         }



        $display_block .= "

        </select>

        <input type=\"hidden\" name=\"op2\" value=\"select2\">

        <p><INPUT type=\"submit\" value=\"Select\"></p>



   </form>";

 echo $sel_divid;

  }



if ($_POST[op2]= "select2")



  {



    $selects = sizeof($sel_drvid);



    $i= 0;

echo $sel_divid;



    while ($i < $selects)

      { 

         $did = $sel_drvid[$i];

 echo $i;

         $i++;

         $make_link = "INSERT INTO GPL_lsdd VALUES ('', '$sel_divid', '$did' )";

         $make_link_res = mysql_query($make_link) or die(mysql_error());



       

      }

  }

  

 

?>



<html>

<head>

<title>Add Drivers to Division</title>

</head>

<body>

<?php echo $display_block; ?>

</body>

</html>