[fraggle]

Hi
This is probably really basic but I need help please.
I have links on a site e.g pagename.php?page=newpage.php and this works fine if newpage.php is in the root folder. but newpage is in folder/newpage.php

I got the link to work with pagename.php?page=folder/newpage.php but i am sure there must be a neater way........

any help please?

[ben.periton]

If all your pages are in the same seperate folder, then on your include statement just use
include('folder/'.$_GET['page'].'.php');

[fraggle]

I will have at least 6 folders initially????

[perleo]

well you could do it this way, set your URL to be like script.php?page=page&folder=folder

so you PHP would be

PHP Code:

<?php

$page = $_GET['page'];

$folder = $_GET['folder'];



include($folder.'/'.$page.'.php');



?>

or if you know what the folders are, you could use switch() , so you url would be script.php?page=page

PHP Code:

<?php

 $page = $_GET['page'];



 switch($page)

   {

           case 'page';

             include('folder/page.php');

           break;

   

            /* repeat the above and change the case and folder path */

    }

 

?>

[gevorgkhc]

not very efficent but w/e

PHP Code:

<?php

if(!$_GET['folder']) {

$folder = ".";

} else {

$folder = "$_GET['folder']";

}



if(!$_GET['page']) {

$page = "index.php";

} else {

$page = "$_GET['page'].php";

}

if(include("$folder/$page")) {

echo "<H1>Error, page does not exist!</H1>"

}

?>

[moronovich]

some people may try:

Code:

//assumption: magic_quotes_gpc is off
browser: http://www.yoursite.com/pagename.php...=\etc\passwd\0

the reason: in C, a string (char *) is terminated by a null character

[Acecool]

All of those examples are insecure.

PHP Code:

if (isset($_GET['page']))

{

     switch ($_GET['page'])

     {

          case '123':

               include('123.php');

          break;



          case '456':

               include('456.php');

          break;



          default:

               include('default.php');

          break;

     }

}

else

{

     include('default.php');

} 

Another way would be:

PHP Code:

// Make the allowed pages array...

$pages = array();

$pages[] = 'default';

$pages[] = '123';

$pages[] = '456';



// Set a simple page variable, change 'default' to the default page

$page = isset($_GET['page']) ? $_GET['page']: 'default';



// If the page is in the allowed pages array, do it to it..

if (in_array($page, $pages))

{

     include ($page);

} 

[fraggle]

so with...

// Make the allowed pages array...
$pages = array();
$pages[] = 'default';
$pages[] = '123';
$pages[] = '456';

if i had over 100 pages, i would need to list them all here?

[Acecool]

Yep..

You could also use:
$pages = array('default', '123', '456');


but the other way is easier to read / manage, as you can comment them:

// Default page...
$pages[] = 'default'

// Some page...
$pages[] = '123';


You could include($_GET['page']); - however this allows anyone to execute unfriendly scripts on your server, so its best to verify it.

[Pixelpyro]

hi Guys,

Just started looking into PHP as a way to better structure my sites using includes etc, so very much a newbie. I came across this thread as the topic similar to something I am looking to do. I have been working with the switch technique which works fine but one of the issues I had was using it with a larger nuber of pages. That is why Acecool's solution of using an array caught my attention.

I have tried to implement the code but get the following errors.

Warning: main(default): failed to open stream: No such file or directory in /hsphere/local/home/copious/pixelpyro.co.uk/structure/array.php on line 22

Warning: main(default): failed to open stream: No such file or directory in /hsphere/local/home/copious/pixelpyro.co.uk/structure/array.php on line 22

Warning: main(): Failed opening 'default' for inclusion (include_path='.:/hsphere/shared/apache/php/lib/php') in /hsphere/local/home/copious/pixelpyro.co.uk/structure/array.php on line 22

I have created the relevant files and the array.php is the main file with the page array code within it. Any ideas what I am doing wrong? Could it be how I am calling the page via a link (http://www.pixelpyro.co.uk/structure...p?page=default)

I should mention that all of the files 123.php, 456.php and default.php are all there.

Thanks for any help..