Having a problem with a large while loop. . .

Spreegem · #1 (**permalink**) 04-30-05, 10:37 PM

I am having a problem with a large while loop I am using in my PHP page. I get the error unexpected $ on line 476 (Last line of the page) I've narrowed the problem down to my while loop, but am not sure what in teh while loop is causing the problem.

PHP Code:


			
while($weap == 0)

        {

        $we_num = 'we_'.$num;

        $weapon = $_POST['weapon']['$we_num'];

        $row = 0;

        

        if($num == 9)

            {

            $weap = 1;

            }

        else

            {

            if($weapon == $num)

                {                    

                while($row == 0)

                    {

                    if($num2 = 26)

                        {

                        $row = 1;

                        }

                    else

                        {

                        $tech = 'weap_tech'.$num2;

                        $type = 'weap_type'.$num2;

                        $dmg = 'weap_dmg'.$num2;

                        

                        $tech2 = 'we_tech'.$num2;

                        $type2 = 'we_type'.$num2;

                        $dmg2 = 'we_dmg'.$num2;

                        

                        $tech3 = $_SESSION['$tech2'];

                        $type3 = $_SESSION['$type2'];

                        $dmg3 = $_SESSION['$dmg2'];

                        if($row2[$tech] == 0)

                            {

                            mysql_query("INSERT INTO ships ($tech, $type, $dmg) VALUES('$tech3', '$type3', '$dmg3') WHERE ship_name = '$ship' AND owner = '$user'") or die (mysql_error());

    

                            $row = 1;

                            $num = $num + 1;

                            $num2 = $num2 + 1;

                            }

                        else

                            {

                            $num2 = $num2 + 1;

                            }

                        }

                    } 

                }

            else

                {

                $num = $num + 1;

                }

            }

        }

NeverMind · #2 (**permalink**) 05-01-05, 04:36 AM

This loop is correct in syntax and all braces are matched.
since you said the error you had pointed the last line, it means that there is a missing brace(s)

however, I noticed this:

PHP Code:


			
$weapon = $_POST['weapon']['$we_num'];

'$we_num' will not evaluate $we because it's inside single quotes. use double quotes to evaluate it.

Acecool · #3 (**permalink**) 05-01-05, 04:44 AM

Correct syntax:

PHP Code:


			
while (condition)

{

     // Do the loop...

}

You do:

PHP Code:


			
while (condition)

          {

          // Do the loop...

          }

Edit: Also you do not need double quotes...

PHP Code:


			
$weapon = $_POST['weapon'][$we_num];

Spreegem · #4 (**permalink**) 05-01-05, 01:15 PM

Thank You both, that solved the error, however it is not inserting the stuff into the database. Here is the updated code.

PHP Code:


			
    while($weap == 0)

        {

        $we_num = 'we_'.$num;

        $weapon = $_POST['weapon']["$we_num"];

        $row = 0;

        

        if($num == 9)

            {

            $weap = 1;

            }

        else

            {

            if($weapon == $num)

                {                    

                while($row == 0)

                    {

                    if($num2 = 26)

                        {

                        $row = 1;

                        }

                    else

                        {

                        $tech = 'weap_tech'.$num2;

                        $type = 'weap_type'.$num2;

                        $dmg = 'weap_dmg'.$num2;

                        

                        $tech2 = 'we_tech'.$num2;

                        $type2 = 'we_type'.$num2;

                        $dmg2 = 'we_dmg'.$num2;

                        

                        $tech3 = $_SESSION["$tech2"];

                        $type3 = $_SESSION["$type2"];

                        $dmg3 = $_SESSION["$dmg2"];

                        if($row2["$tech"] == 0)

                            {

                            mysql_query("INSERT INTO ships ($tech, $type, $dmg) VALUES('$tech3', '$type3', '$dmg3') WHERE ship_name = '$ship' AND owner = '$user'") or die (mysql_error());

    

                            $row = 1;

                            $num = $num + 1;

                            $num2 = $num2 + 1;

                            }

                        else

                            {

                            $num2 = $num2 + 1;

                            }

                        }

                    } 

                }

            else

                {

                $num = $num + 1;

                }

            }

        }

alabaster_lynch · #5 (**permalink**) 05-01-05, 01:51 PM

mysql_query("INSERT INTO ships ($tech, $type, $dmg) VALUES('$tech3', '$type3', '$dmg3') WHERE ship_name = '$ship' AND owner = '$user'") or die (mysql_error());

are $tech,$type, $dmg valid names in your db?

and also is this written so the query will write over an already existant row?

Spreegem · #6 (**permalink**) 05-01-05, 03:03 PM

There is no row to overwrite, but. . .

$tech = weap_tech1
weap_tech1, or whatever the number is, is a valid name in the database. Is it a problem with me using a variable for the name the values should be inserted into? I have bolded it below. . .

mysql_query("INSERT INTO ships ($tech, $type, $dmg) VALUES('$tech3', '$type3', '$dmg3') WHERE ship_name = '$ship' AND owner = '$user'") or die (mysql_error());

alabaster_lynch · #7 (**permalink**) 05-01-05, 04:09 PM

Quote:

Originally Posted by Spreegem

There is no row to overwrite, but. . .

$tech = weap_tech1
weap_tech1, or whatever the number is, is a valid name in the database. Is it a problem with me using a variable for the name the values should be inserted into? I have bolded it below. . .

mysql_query("INSERT INTO ships ($tech, $type, $dmg) VALUES('$tech3', '$type3', '$dmg3') WHERE ship_name = '$ship' AND owner = '$user'") or die (mysql_error());

I don't think it would be a problem, except I would think you would need some single quotes around them....also one think that I have to ask is why do you have conditional statements in an insert?

what does fields does your ships table have?

Acecool · #8 (**permalink**) 05-01-05, 04:17 PM

Single quotes in double quotes work fine..

Why do you need a WHERE ship_name='...'?
If you want to UPDATE a row, then use the UPDATE row syntax..

INSERT INTO will create a new row, and you do not need a WHERE...

Code:

UPDATE table SET column='value', another='another value' WHERE id='##'

alabaster_lynch · #9 (**permalink**) 05-01-05, 05:05 PM

Well I am glad someone agrees with me.....

Spreegem · #10 (**permalink**) 05-01-05, 05:57 PM

Opps. . . Yeah, I meant update, can't believe I didn't notice that.

Still not working for some reason. . . I just tried echoing $weapon, $tech, $tech3, and the others, but nothing gets echoed, none of them have values it appears.

Here's the updated code for the loop

PHP Code:


			
$num = 1;

$num2 = 1;        

    while($weap == 0)

        {

        $we_num = 'we_'.$num;

        $weapon = $_POST['weapon']["$we_num"];

        $row = 0;

        

        if($num == 9)

            {

            $weap = 1;

            }

        else

            {

            if($weapon == $num)

                {                    

                while($row == 0)

                    {

                    if($num2 = 26)

                        {

                        $row = 1;

                        }

                    else

                        {

                        $tech = 'weap_tech'.$num2;

                        $type = 'weap_type'.$num2;

                        $dmg = 'weap_dmg'.$num2;

                        

                        $tech2 = 'we_tech'.$num2;

                        $type2 = 'we_type'.$num2;

                        $dmg2 = 'we_dmg'.$num2;

                        

                        $tech3 = $_SESSION["$tech2"];

                        $type3 = $_SESSION["$type2"];

                        $dmg3 = $_SESSION["$dmg2"];

                        ?>

                        <p>

                        <?

                        echo $weapon;

                        echo $tech;

                        echo $type;

                        echo $dmg;

                        

                        echo $tech3;

                        echo $type3;

                        echo $dmg3;

                        ?>

                        </p>

                        <?

                        if($row2["$tech"] == 0)

                            {

                            mysql_query("UPDATE ships '$tech' = '$tech3', '$type' = '$type3', '$dmg' = '$dmg3' WHERE ship_name = '$ship' AND owner = '$user'") or die (mysql_error());

    

                            $row = 1;

                            $num = $num + 1;

                            $num2 = $num2 + 1;

                            }

                        else

                            {

                            $num2 = $num2 + 1;

                            }

                        }

                    } 

                }

            else

                {

                $num = $num + 1;

                }

            }

        }