[Programme]

I have been at this for a while, so i'll just explain: The sql query will result in one or more rows. i want to get a value from all the row and add them to a string, seperated by a comma before i add this to the screen.

The sql bit:

Code:

<?php

$select = "SELECT * FROM table WHERE id = '$uid' AND type = 'type'";
$data = mysql_db_query($sql['data'], $select) or die("Select Failed!");
  	
while ($row = mysql_fetch_array($data))
   {
      $art = $row['article_id'];		
   } 
  
$tpl->assign("article", "$art,");

?>

So if the query found 3 rows with the article_id values; art1, art2 and art3 the template assign would then be; and the result when i print this to the screen would be:

art1, art2, art3

How is this done in a simple way? Thanks!

[NeverMind]

PHP Code:

while ($row = mysql_fetch_array($data))

   {

      $arts[] = $row['article_id'];        

   }



$art = implode(', ', $arts);



$tpl->assign("article", $art); 

I assigned each article_id to the array $arts[] and then used implode() function to put all ids in a string seperated by ", "

[Programme]

I actually found a way to do this, but your way was alot easier, so that is what i'll use. Thanks. I do however have another problem. Here is the code i got to after a while. The values i get are actually ids refering to a rel name in another table, i need these names. So insted of the values; 1, 2, 3 i get name, name, name. You see?

PHP Code:

<?php



while ($row = mysql_fetch_array($data))

   {

      $arts = $row['article_id'];        

      

      $select = "SELECT * FROM realname WHERE uid = '$arts'";

      $data = mysql_db_query($sql['data'], $select) or die("Select Failed!");

      $row = mysql_fetch_array($data);

          

      $writers[] = $row['name'];

   }



$art = implode(', ', $writers);



$tpl->assign("comic_writer", $art); 



?>

Problem with this is that i only get the first name, not the others.

[NeverMind]

maybe this problem is happing is because you are using the same variables names from outside the loop ($data, $row)
try changing them and use mysql_query() instead of mysql_db_query(). are you connecting to same DB
mysql_db_query() is deprecated.
so try this:

PHP Code:

while ($row = mysql_fetch_array($data))

   {

      

      $fetch = mysql_query("SELECT name FROM realname WHERE uid='$row[article_id]' LIMIT 1")or

      die("Select Failed!");

      $realname = mysql_fetch_assoc($fetch);

          

      $writers[] = $realname['name'];

   }



$art = implode(', ', $writers);



$tpl->assign('comic_writer', $art); 

[Programme]

Ah, there we go. Things looking good. My script uses mysql_db_query alot. Should i rewrite and use mysql_query instead?

[kenetix]

Originally Posted by Programme

Ah, there we go. Things looking good. My script uses mysql_db_query alot. Should i rewrite and use mysql_query instead?

i think theyre about the same, one is probably the same function with a newer name.

[NeverMind]

Originally Posted by Programme

Ah, there we go. Things looking good. My script uses mysql_db_query alot. Should i rewrite and use mysql_query instead?

it's better to replace them.
this is a quote from PHP manual:

Note: This function has been deprecated since PHP 4.0.6. Do not use this function. Use mysql_select_db() and mysql_query() instead.

besides that you are only using one DB, so there is no need to reselect the same DB each time you execute a query.

[dennispopel]

Hello,

Why don't just use table join to select all the writers in a single query?