[ozwald]

I've got a simple BB code to HTML parser that I'm using. Here's the code for that:

PHP Code:

function bb2html($text) {

  $bbcode = array("<", ">",

    "[list]", "[*]", "[/list]", 

    "[img]", "[/img]", 

    "[b]", "[/b]", 

    "[u]", "[/u]", 

    "[i]", "[/i]",

    '[color="', "[/color]",

    "[size=\"", "[/size]",

    '[url="', "[/url]",

    "[code]", "[/code]",

  '"]');

  $htmlcode = array("&lt;", "&gt;",

    "<ul>", "<li>", "</ul>", 

    "<img src=", "</img>", 

    "<b>", "</b>", 

    "<u>", "</u>", 

    "<i>", "</i>",

    '<font color="', "</font>",

    "<span style=\"font-size:", "</span>",

    '<a href="', "</a>",

    "<code>", "</code>",

  '">');

  $newtext = str_replace($bbcode, $htmlcode, $text);

  return $newtext;

} 

It works perfectly fine with PHP 4.3.9, but when used with PHP 5, the font color, font size, image, and url conversions get messed up. For example, here is what a url that gets inserted into the database after being parsed looks like:

[CODE]
[url=\"http://www.google.com\">Google</a>
[/CODE]

Does anyone know how I can fix this? Thanks.

[kenetix]

Originally Posted by ozwald

I've got a simple BB code to HTML parser that I'm using. Here's the code for that:

PHP Code:

function bb2html($text) {

  $bbcode = array("<", ">",

    "[list]", "[*]", "[/list]", 

    "[img]", "[/img]", 

    "[b]", "[/b]", 

    "[u]", "[/u]", 

    "[i]", "[/i]",

    '[color="', "[/color]",

    "[size=\"", "[/size]",

    '[url="', "[/url]",

    "[code]", "[/code]",

  '"]');

  $htmlcode = array("&lt;", "&gt;",

    "<ul>", "<li>", "</ul>", 

    "<img src=", "</img>", 

    "<b>", "</b>", 

    "<u>", "</u>", 

    "<i>", "</i>",

    '<font color="', "</font>",

    "<span style=\"font-size:", "</span>",

    '<a href="', "</a>",

    "<code>", "</code>",

  '">');

  $newtext = str_replace($bbcode, $htmlcode, $text);

  return $newtext;

} 

It works perfectly fine with PHP 4.3.9, but when used with PHP 5, the font color, font size, image, and url conversions get messed up. For example, here is what a url that gets inserted into the database after being parsed looks like:

[CODE]
[url=\"http://www.google.com\">Google</a>
[/CODE]

Does anyone know how I can fix this? Thanks.

you are simply using the str_replace function, that simply replaces a string with another string. It worked in php 4 because php4 is probably more lenient with code parsings.

Example:
you are replacing <a href=" with [url="
not only are you not replacing the closing brace (>), it will not work if the person keyed in <a **** href=" , where **** represents spaces.