[mdhall]

I'm using an if/else statement on a page named "results.php". When a user logs in from a form, they add a name and password, which are passed to "results.php" with no problem. When the name or password are incorrect, they get the "else" statement, showing that there is an error. This part is fine. However, when the name and password are correct, "results.php" displays as it should, but the "else" (error) statement is displaying at the top of the page. Heres what I'm using...

$student_number = $_POST['student_number'];
$unique_pass = $_POST['unique_pass'];

If($student_number=="student_number" && $unique_pass=="unique_pass")
{
print "Access Confirmed";<br>
}
Else
{ print "Access Denied<br>";
print "Your Student Number or Password is incorrect.<br>";
print "Please try again. Login Page";
}
?>
Any suggestions?

[NeverMind]

but the "else" (error) statement is displaying at the top of the page.

can you explain this ? what exactly do you see ?

and note that you wrote :

PHP Code:

print "Access Confirmed";<br> 

and the <BR> should be inside the quote ..like this :

PHP Code:

print "Access Confirmed<br>"; 

and also use the single quote instead of the double one as long as you don't have variables inside .. using double quote makes your script slower .. try this one instead :

PHP Code:

<?php

$student_number = $_POST['student_number'];

$unique_pass = $_POST['unique_pass'];



If ($student_number=="student_number" && $unique_pass=="unique_pass") {

echo 'Access Confirmed<br>';

} else { 

echo 'Access Denied<br>';

echo 'Your Student Number or Password is incorrect.<br>';

echo 'Please try again. Login Page';

}

?>

also as you can see I used echo instead of print .. but it doesn't matter anyway ..

[ermau]

Because I seriously doubt that everyone's number is "student_number" and their pass is "unique_pass". You need to retrieve their number and password from a database or whatever and then compare their entered items to those items.

[NeverMind]

Originally Posted by ermau

Because I seriously doubt that everyone's number is "student_number" and their pass is "unique_pass". You need to retrieve their number and password from a database or whatever and then compare their entered items to those items.

that's for sure ,, but I think he showed us only an example of his script ...

[mdhall]

I'm not familiar with if/else statements, so sorry if this is a pretty basic thing. The "results.php" is a query that matches the student_number and unique_pass entered from a form, and shows that users information. ( student_number and unique_pass are 2 fields of the db table). The query and results work fine. If the wrong name/password is entered, the else statement,

Access Denied.
Your Student Number or Password is incorrect.
Please try again.

is displayed instead, with nothing else. That part is fine also.

What isnt quite right is that, if the username and password are correct, then

Access Denied.
Your Student Number or Password is incorrect.
Please try again.

is still displaying at the top of the results.php page, then the rest of the results page is displayed just fine. The "access confirmed" part is no big deal, I really don't want it to display when the user name and password are correct. This is a sample code someone gave to me, so I was trying to work it in here. Hope that makes it a little clearer. I tried the code as you added above, but it still does the same thing.

[ermau]

Can you post all of your exact code from that file?

[mdhall]

OK

The form input...

Student Enrollment Number:<br>
<input type=text name="student_number" size=30><p>
Password:<br>
<input type=text name="unique_pass" size=30><p>
<input type=submit name=submit value="View Records">

The reviewrecords.php page...

php
include("dbinfo.inc.php");//connection string
$student_number = $_POST['student_number'];
$unique_pass = $_POST['unique_pass'];
If ($student_number=="student_number" && $unique_pass=="unique_pass") {
echo 'Access Confirmed<br>'; //not necessary to display
}
Else
{
echo 'Access Denied<br>';
echo 'Your Student Number or Password is incorrect.<br>';
echo 'Please try again. Login Page';
}
$dbh=mysql_connect ("localhost", "$username", "$password") or die ('I cannot connect to the database because: ' . mysql_error());
mysql_select_db ("$database");
$query=("SELECT * FROM studentinfo WHERE student_number='$student_number' AND unique_pass='$unique_pass'");
$result = mysql_query($query);
$num=mysql_num_rows($result);

$i = 0;

echo "<table width=500 border=1 cellpadding=5 cellspacing=0><tr>";
while ($i < $num):
$id=mysql_result($result,$i,"id");
$fname=mysql_result($result,$i,"fname");
$lname=mysql_result($result,$i,"lname");
$student_number=mysql_result($result,$i,"student_n umber");
$unique_pass=mysql_result($result,$i,"unique_pass" );
$grade_level=mysql_result($result,$i,"grade_level" );
$total_days=mysql_result($result,$i,"total_days");
$total_attend=mysql_result($result,$i,"total_atten d");
$total_absent=mysql_result($result,$i,"total_absen t");

echo "<td>$fname $lname<br>
$student_number<br>
$grade_level<br>
$unique_pass<br>
$total_days<br>
$total_attend<br>
$total_absent
echo "</td></tr>";
$i++;
endwhile;
/php

[ermau]

Ya, that's your problem, your doing it all wrong. You should be checking $num, if it equals 0 then they dont exist or haven't logged in with the right password, otherwise they have.

[mdhall]

Originally Posted by ermau

Ya, that's your problem, your doing it all wrong. You should be checking $num, if it equals 0 then they dont exist or haven't logged in with the right password, otherwise they have.

How would I set that up? Like I said, this is a new area for me.

[ermau]

You've already done it....

Remove this:

PHP Code:

If ($student_number=="student_number" && $unique_pass=="unique_pass") { 

echo 'Access Confirmed<br>'; //not necessary to display

}

Else

{ 

echo 'Access Denied<br>'; 

echo 'Your Student Number or Password is incorrect.<br>'; 

echo 'Please try again. Login Page'; 

} 

And add this:

PHP Code:

if ($num == 0)

{

echo 'denied';

}

else

{

echo 'welcome';

} 

After:

PHP Code:

$query=("SELECT * FROM studentinfo WHERE student_number='$student_number' AND unique_pass='$unique_pass'");

$result = mysql_query($query);

$num=mysql_num_rows($result);