[keefermedia]

I am getting this error:

Parse error: parse error, unexpected $ in line 27

not sure what Is going on, but I am sure an expert can look and see the problem right away.

Will this code successfully take variables from my form:

Code:

<form action="http://www.keefermedia.com/ohmygolf/checkout.php" method="post">
        <div align="center">
          <table width="670" border="0">
            <tr> 
              <td width="410"> <div align="right">
<p align="center"><font face="Arial, Helvetica, sans-serif"><strong>Begin 
                    Checkout</strong></font></p>
                  <p><font face="Arial, Helvetica, sans-serif">
                    Name: 
                    <input name="orderName" type="text" size="30" maxlength="30">
                    <br>
                    Address: 
                    <input name="orderAdd" type="text" id="Address2" size="30" maxlength="50">
                    <br>
                    Address2: 
                    <input name="orderAdd2" type="text" size="30" maxlength="50">
                    <br>
                    City: 
                    <input name="orderCity" type="text" size="30" maxlength="30">
                    <br>
                    State: 
                    <select name="orderState">
                      <option value="none">Select State</option>
                      <option value="Alabama">Alabama</option>
                      <option value="Alaska">Alaska</option>
                      <option value="Alberta">Alberta</option>
                      <option value="Arizona">Arizona</option>
                      <option value="Arkansas">Arkansas</option>
                      <option value="British Columbia">British Columbia</option>
                      <option value="California">California</option>
                      <option value="Colorado">Colorado</option>
                      <option value="Connecticut">Connecticut</option>
                      <option value="Delaware">Delaware</option>
                      <option value="District of Columbia">District of Columbia</option>
                      <option value="Florida">Florida</option>
                      <option value="Georgia">Georgia</option>
                      <option value="Guam">Guam</option>
                      <option value="Hawaii">Hawaii</option>
                      <option value="Idaho">Idaho</option>
                      <option value="Illinois">Illinois</option>
                      <option value="Indiana">Indiana</option>
                      <option value="Iowa">Iowa</option>
                      <option value="Kansas">Kansas</option>
                      <option value="Kentucky">Kentucky</option>
                      <option value="Louisiana">Louisiana</option>
                      <option value="Maine">Maine</option>
                      <option value="Manitoba">Manitoba</option>
                      <option value="Maryland">Maryland</option>
                      <option value="Massachusetts">Massachusetts</option>
                      <option value="Michigan">Michigan</option>
                      <option value="Minnesota">Minnesota</option>
                      <option value="Mississippi">Mississippi</option>
                      <option value="Missouri">Missouri</option>
                      <option value="Montana">Montana</option>
                      <option value="Nebraska">Nebraska</option>
                      <option value="Nevada">Nevada</option>
                      <option value="New Brunswick">New Brunswick</option>
                      <option value="New Hampshire">New Hampshire</option>
                      <option value="New Jersey">New Jersey</option>
                      <option value="New Mexico">New Mexico</option>
                      <option value="New York">New York</option>
                      <option value="North Carolina">North Carolina</option>
                      <option value="North Dakota">North Dakota</option>
                      <option value="Nova Scotia">Nova Scotia</option>
                      <option value="Ohio">Ohio</option>
                      <option value="Oklahoma">Oklahoma</option>
                      <option value="Ontario">Ontario</option>
                      <option value="Oregon">Oregon</option>
                      <option value="Pennsylvania">Pennsylvania</option>
                      <option value="Quebec">Quebec</option>
                      <option value="Rhode Island">Rhode Island</option>
                      <option value="South Carolina">South Carolina</option>
                      <option value="South Dakota">South Dakota</option>
                      <option value="Tennessee">Tennessee</option>
                      <option value="Texas">Texas</option>
                      <option value="Utah">Utah</option>
                      <option value="Vermont">Vermont</option>
                      <option value="Virginia">Virginia</option>
                      <option value="Washington">Washington</option>
                      <option value="West Virginia">West Virginia</option>
                      <option value="Wisconsin">Wisconsin</option>
                      <option value="Wyoming">Wyoming</option>
                    </select>
                    Zip: 
                    <input name="orderZip" type="text" size="10" maxlength="10">
                    <br>
                    Country: 
                    <select name="orderCountry">
                      <option value="United States" selected>United States</option>
                      <option value="Afghanistan">Afghanistan</option>
                      <option value="Albania">Albania</option>
                      <option value="Algeria">Algeria</option>
                      <option value="Angola">Angola</option>
                      <option value="Antigua and Barbuda">Antigua and Barbuda</option>
                      <option value="Argentina">Argentina</option>
                      <option value="Armenia">Armenia</option>
                      <option value="Aruba">Aruba</option>
                      <option value="Australia">Australia</option>
                      <option value="Austria">Austria</option>
                      <option value="Azerbaidjan">Azerbaidjan</option>
                      <option value="Bahamas">Bahamas</option>
                      <option value="Bahrain">Bahrain</option>
                      <option value="Banglades">Bangladesh</option>
                      <option value="Barbados">Barbados</option>
                      <option value="Belarus">Belarus</option>
                      <option value="Belgium">Belgium</option>
                      <option value="Belize">Belize</option>
                      <option value="Bermuda">Bermuda</option>
                      <option value="Bolivia">Bolivia</option>
                      <option value="Bosnia-Herzegovina">Bosnia-Herzegovina</option>
                      <option value="Brazil">Brazil</option>
                      <option value="Cambodia">Cambodia</option>
                      <option value="Cameroon">Cameroon</option>
                      <option value="Canada">Canada</option>
                      <option value="Cape Verde">Cape Verde</option>
                      <option value="Cayman Islands">Cayman Islands</option>
                      <option value="Central African Rep.">Central African Rep.</option>
                      <option value="Chad">Chad</option>
                      <option value="Chile">Chile</option>
                      <option value="China">China</option>
                      <option value="Colombia">Colombia</option>
                      <option value="Congo">Congo</option>
                      <option value="Costa Rica">Costa Rica</option>
                      <option value="Croatia">Croatia</option>
                      <option value="Cuba">Cuba</option>
                      <option value="Cyprus">Cyprus</option>
                      <option value="Czech Republic">Czech Republic</option>
                      <option value="Denmark">Denmark</option>
                      <option value="Dominica">Dominica</option>
                      <option value="Dominican Republic">Dominican Republic</option>
                      <option value="Ecuador">Ecuador</option>
                      <option value="Egypt">Egypt</option>
                      <option value="El Salvador">El Salvador</option>
                      <option value="Estonia">Estonia</option>
                      <option value="Ethiopia">Ethiopia</option>
                      <option value="Finland">Finland</option>
                      <option value="France">France</option>
                      <option value="Georgia">Georgia</option>
                      <option value="Germany">Germany</option>
                      <option value="Greece">Greece</option>
                      <option value="Guatemala">Guatemala</option>
                      <option value="Holland">Holland</option>
                      <option value="Honduras">Honduras</option>
                      <option value="Hungary">Hungary</option>
                      <option value="Iceland">Iceland</option>
                      <option value="India">India</option>
                      <option value="Indonesia">Indonesia</option>
                      <option value="Ireland">Ireland</option>
                      <option value="Israel">Israel</option>
                      <option value="Italy">Italy</option>
                      <option value="Ivory Coast">Ivory Coast</option>
                      <option value="Jamaica">Jamaica</option>
                      <option value="Japan">Japan</option>
                      <option value="Jordan">Jordan</option>
                      <option value="Kenya">Kenya</option>
                      <option value="Korea (South)">Korea (South)</option>
                      <option value="Kuwait">Kuwait</option>
                      <option value="Lithuania">Lithuania</option>
                      <option value="Luxembourg">Luxembourg</option>
                      <option value="Malaysia">Malaysia</option>
                      <option value="Mexico">Mexico</option>
                      <option value="Monaco">Monaco</option>
                      <option value="Mongolia">Mongolia</option>
                      <option value="Morocco">Morocco</option>
                      <option value="Mozambique">Mozambique</option>
                      <option value="Nepal">Nepal</option>
                      <option value="Netherlands">Netherlands</option>
                      <option value="New Zealand">New Zealand</option>
                      <option value="Nicaragua">Nicaragua</option>
                      <option value="Niger">Niger</option>
                      <option value="Nigeria">Nigeria</option>
                      <option value="Norway">Norway</option>
                      <option value="Panama">Panama</option>
                      <option value="Paraguay">Paraguay</option>
                      <option value="Peru">Peru</option>
                      <option value="Philippines">Philippines</option>
                      <option value="Poland">Poland</option>
                      <option value="Portugal">Portugal</option>
                      <option value="Romania">Romania</option>
                      <option value="Russian Federation">Russian Federation</option>
                      <option value="Saudi Arabia">Saudi Arabia</option>
                      <option value="Senegal">Senegal</option>
                      <option value="Seychelles">Seychelles</option>
                      <option value="Sierra Leone">Sierra Leone</option>
                      <option value="Singapore">Singapore</option>
                      <option value="Slovak Republic">Slovak Republic</option>
                      <option value="Slovenia">Slovenia</option>
                      <option value="Somalia">Somalia</option>
                      <option value="South Africa">South Africa</option>
                      <option value="Spain">Spain</option>
                      <option value="Sri Lanka">Sri Lanka</option>
                      <option value="St. Lucia">St. Lucia</option>
                      <option value="Sweden">Sweden</option>
                      <option value="Switzerland">Switzerland</option>
                      <option value="Tadjikistan">Tadjikistan</option>
                      <option value="Taiwan">Taiwan</option>
                      <option value="Thailand">Thailand</option>
                      <option value="Trinidad">Trinidad</option>
                      <option value="Turkey">Turkey</option>
                      <option value="Ukraine">Ukraine</option>
                      <option value="United Arab Emirates">United Arab Emirates</option>
                      <option value="United Kingdom">United Kingdom</option>
                      <option value="Uruguay">Uruguay</option>
                      <option value="Uzbekistan">Uzbekistan</option>
                      <option value="Venezuela">Venezuela</option>
                      <option value="Vietnam">Vietnam</option>
                    </select>
                    <br>
                    Email: 
                    <input name="orderEmail" type="text" size="20" maxlength="30">
                    <input type="hidden" name="orderCartId" value="GetCartId()">
                    </font></p>
</div></td>
              <td width="250"><div align="center"> 
                  <p><font face="Arial, Helvetica, sans-serif">
<input type="submit" name="Submit" value="Submit Shipping Info">

With this Form processing PHP:

PHP Code:

<?

function mysql_safe($var)

{

trim($var);

strip_tags($var);

htmlspecialchars($var);

eregi_replace("`", "", $var);

addslashes();

}



$orderName = mysql_safe($_POST['orderName']);

$orderAdd = mysql_safe($_POST['orderAdd']);

$orderAdd2 = mysql_safe($_POST['orderAdd2']);

$orderCity = mysql_safe($_POST['orderCity']);

$orderState = mysql_safe($_POST['orderState']);

$orderCountry = mysql_safe($_POST['orderCountry']);

$orderZip = mysql_safe($_POST['orderZip']);

$orderEmail = mysql_safe($_POST['orderEmail']);

$orderCartCookie = mysql_safe($_POST['orderCartID']);



include 'db.php';

$cxn = @ConnectToDb($dbServer, $dbUser, $dbPass, $dbName); 



$request = 'INSERT INTO orders VALUES (now (),"'.$orderName.'","'.$orderAdd.'","'.$orderAdd2.'","'.$orderCity.'","'.$orderState.'","'.$orderCountry.'","'.$orderZip.'","'.$orderEmail.'","'.$orderCartCookie."')'; 

mysql_query($request) or die('Insert failed: ' . mysql_error()); 



?>

[keefermedia]

thanks for formatting...I jsut read the thread on how to do it. I will do it properly next time. thanks again poet.

[Christian]

Originally Posted by keefermedia

thanks for formatting...I jsut read the thread on how to do it. I will do it properly next time. thanks again poet.

No Problem, That what I'm here for I need a vacation! jk

[mab]

The most immediate problem with this is that there is a mismatch of quotes near the end of the $request string...

This string is overly complex and can be simplified because variables are parsed inside double-quoted strings. The following will work and make the above type of error easier to avoid and easier to find -

PHP Code:

$request = "INSERT INTO orders VALUES (now(), '$orderName', '$orderAdd', '$orderAdd2', '$orderCity', '$orderState', '$orderCountry', '$orderZip', '$orderEmail', '$orderCartCookie')"; 

[So that no one askes about the spaces after the coma's in the above that are not in the original, they are only to keep the PHP code post wrapping function from inserting its' own space somewhere in the string.]

The next problem that will prevent this code from working is that the functions used within the mysql_safe function are not used properly. All of these functions return a string and need to be assigned to a variable. Additionally, the addslashes() function is missing a parameter. Finally, the mysql_safe function must return a value, which it does not do...

[keefermedia]

Thank you. Silly syntax error; the problem with me being a cut and paste programmer. I have made your revisions and then some...all is working.

But now... I have some "good practice" questions, but those will move to another thread

Thanks again.