[landboy]

Hello,

I am using Linux and I have to script that takes the result and addes 1 too it. But it keeps on adding two too it.. Yet when I print the variables they are only getting added by one.. And the same variables show as being updated by twice when in a mysql_query

Code..

PHP Code:

    php:$query = mysql_query("SELECT total_hits, total_uniques FROM stats LIMIT 1") or die("Error1".mysql_error());

    $data = mysql_fetch_array($query);

    $total_hits = $data['total_hits'];

    $total_uniques = $data['total_uniques'];



    // Get info

    $ip = $_SERVER['REMOTE_ADDR'];



    $vist = mysql_query("SELECT ip FROM log WHERE ip='$ip' LIMIT 1") or die("Error2".mysql_error());

    $visits = mysql_fetch_array($vist);

    if(mysql_num_rows($vist) == 1) {

      $new_u = $total_uniques;

    }else{

      $new_u = $total_uniques+1;

    }



    $new_h = $total_hits+1;



    // Update

    mysql_query("UPDATE stats SET total_hits='$new_h', total_uniques='$new_u'") or die("Error3".mysql_error());

    ?> 

But when I run it.. It addes 2 to the mysql database.. Insted of one.. Is the script somehow getting run twice??

- Steve

[ngcomputing]

Dunno if this helps. I shortened up the code a little bit as you can see. In addition, if you set a session variable to detect if the counter has already been ran, a user can't click on the refresh button all day and update your total_hits over and over. Typically, I would include the counter code in each page of the site via an include file.

Also check your mysql fields and make sure they are the right data types, if your using something like tinyint your going to run into trouble!

PHP Code:

<?php 



@session_start();



function update_counters(){

 

    $query = mysql_query("SELECT total_hits, total_uniques FROM stats LIMIT 1") or die("Error1".mysql_error());

    $data = mysql_fetch_array($query);

    $total_hits = $data['total_hits'];

    $total_uniques = $data['total_uniques'];



    // Get info

    $ip = $_SERVER['REMOTE_ADDR'];



    $vist = mysql_query("SELECT ip FROM log WHERE ip='$ip' LIMIT 1") or die("Error2".mysql_error());



    if(mysql_num_rows($vist) == 0) {

            $total_uniques++;

    }



    $total_hits++;



    // Update

    mysql_query("UPDATE stats SET total_hits='$total_hits', total_uniques='$total_uniques'") or die("Error3".mysql_error());



return $total_uniques;



} // end updatecounters() function





if(!isset($UNIQ_VISITORS)){



 session_register['UNIQ_VISITORS'];

 $UNIQ_VISITORS = update_counters();





}





// Now you can display $UNIQ_VISITORS on your pages anywhere to show the number of unique visitors to the site since its value was set by the function update_counters()



echo "Unique Site Visitors : $UNIQ_VISITORS";





?>

[Grabber]

mysql_query("UPDATE stats SET total_hits='$new_h', total_uniques='$new_u'")

why are you using single quote for integer values in the query?

secondly your error explanation is confusing you said it addes two to the mysql database. well, of course it will add two if the user is ip is unique, one for $total_uniques and one for $total_hits ..

So explain please which one of these two variables is incremented twice?