PHP include not working in echo statement
07-02-06, 07:30 AM
Newbie Coder
Join Date: Jun 2006
Location: Boston
Posts: 31
Thanks: 0
Thanked 0 Times in 0 Posts
PHP include not working in echo statement
So, I had posted the other day, and got some great help. Now I'm stuck again.
I managed to get my if else statement working correctly. However, now, in my "include" statement, it won't work, when called from the "echo" statement, and I can't figure out why.
Here's my original code (which is sloppy, I know, I'm still learning)
PHP Code:
<?
= "XXXXXXXXXXXx" ;
$password = "XXXXXXXX" ;
$database = "XXXXXXXXXXXXX" ;
mysql_connect ( "XXXXXXXXXXXXXX" , $username , $password );
mysql_select_db ( $database ) or die( "Unable to select database" );
$query = "SELECT * FROM reviews WHERE movieid=' $movieid '" ;
$result = mysql_query ( $query );
$num = mysql_numrows ( $result );
mysql_close ();
"" ;
$i = 0 ;
//while ($i < $num) {
while ( $row = mysql_fetch_array ( $result )) {
$title = $row [ 'title' ];
$stars = $row [ 'stars' ];
$rating = $row [ 'rating' ];
$main_cast = $row [ 'main_cast' ];
$review = $row [ 'review' ];
$runtime = $row [ 'runtime' ];
$release_dvd = $row [ 'release_dvd' ];
$release_theater = $row [ 'release_theater' ];
$reviewed_by = $row [ 'reviewed_by' ];
$links = $row [ 'links' ];
$director = $row [ 'director' ];
$writer = $row [ 'writer' ];
$tags = $row [ 'tags' ];
$poster = $row [ 'poster' ];
$date_written = $row [ 'date_written' ];
$page_title = $row [ 'page_title' ];
$amazon = $row [ 'amazon' ];
$netflix = $row [ 'netflix' ];
?>
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<? echo $tags ; ?> ">
<? echo $page_title ; ?> </title>
<? echo "" ; $i ++;} ?> <b>Movie Title:</b> <? echo $title ; ?> <br><b>Director:</b> <? echo $director ; ?> <br><b>Written by:</b> <? echo $writer ; ?> <br> <b>Main Cast:</b> <? echo $main_cast ; ?> <br><b>MPAA Rating:</b> <? echo $rating ; ?> <br><b>Runtime:</b> <? echo $runtime ?> <br> <b>Reviewed by: </b><? echo $reviewed_by ; ?> <br>
<? echo $stars ; ?> .gif" alt="Rating"></center>
<? echo $release_theater ; ?> <br><b>DVD Release Date:</b> <? echo $release_dvd ; ?> <br><img src="http://www.moviesnobs.net/images/sub_bullet.gif" alt=""> <a href="http://www.netflix.com/AddToQueue?movieid=<? echo $netflix ; ?> " target="_blank" onmouseover="window.status='';return true" onmouseout="window.status='';return true" target="_blank" title="Add <? echo $title ; ?> To Your Netflix Queue">Netflix <? echo $title ; ?> </a><Br><img src="http://www.moviesnobs.net/images/sub_bullet.gif" alt=""> <a href=" <? echo $amazon ; ?> " title="Buy <? echo $title ; ?> at Amazon.com" target="_blank" onmouseover="window.status='';return true" onmouseout="window.status='';return true">Buy <? echo $title ; ?> at Amazon</a><img src="http://www.assoc-amazon.com/e/ir?t=moviesnobs-20&l=ur2&o=1" width="1" height="1" border="0" alt="" style="border:none !important; margin:0px !important;" /><br>
<? include( "boxes/boxes.php" ) ?>
<? echo " $title " ; ?> </span><br>
<? echo " $date_written " ; ?> <br><br><img src="http://www.moviesnobs.net/images/content/email_send.gif" alt=""> <a href="refer_a_review.php" onmouseover="window.status='';return true" onmouseout="window.status='';return true" target="_blank" title="Send this review to a friend!">E-mail this review to a friend</a> <img src="http://www.moviesnobs.net/images/content/printer.gif" alt=""> <a href="print_view.php?movieid=<? echo " $movieid " ; ?> " target="_blank" title="Printable Version">Printable View</a></center><Br>
<? echo " $poster " ; ?> " border="2" align="right" hspace="15" vspace="5" alt="<? echo $page_title ; ?> "><? echo " $review " ; ?> <p><B>See more reviews for the main cast of <? echo " $title " ; ?> </b>: <? echo $main_cast ; ?> </blockquote></blockquote>
<? include( "footer.php" ) ?>
</body>
My php includes work fine in this context. However, here's the code I'm trying to change to (to handle errors better), and the php includes don't work in my echo statement. Any ideas why?
PHP Code:
<?
= "XXXXXXXXX" ;
$password = "XXXXXXXXX" ;
$database = "XXXXXXXXXXXXX" ;
mysql_connect ( "XXXXXXXXXX" , $username , $password );
mysql_select_db ( $database ) or die( "Unable to select database" );
$query = "SELECT * FROM reviews WHERE movieid=' $movieid '" ;
$result = mysql_query ( $query ) or die( 'Query failed: ' . mysql_error ());
$num = mysql_numrows ( $result );
mysql_close ();
"" ;
//while ($i < $num) {
while ( $row = mysql_fetch_array ( $result )){
$tags = $row [ 'tags' ];
$stars = $row [ 'stars' ];
$rating = $row [ 'rating' ];
$main_cast = $row [ 'main_cast' ];
$review = $row [ 'review' ];
$runtime = $row [ 'runtime' ];
$release_dvd = $row [ 'release_dvd' ];
$release_theater = $row [ 'release_theater' ];
$reviewed_by = $row [ 'reviewed_by' ];
$links = $row [ 'links' ];
$director = $row [ 'director' ];
$writer = $row [ 'writer' ];
$tags = $row [ 'tags' ];
$poster = $row [ 'poster' ];
$date_written = $row [ 'date_written' ];
$page_title = $row [ 'page_title' ];
$amazon = $row [ 'amazon' ];
$netflix = $row [ 'netflix' ];
$title = $row [ 'title' ];
?>
<?
if( mysql_num_rows ( $result ) === 0 )
"No Movie Review Found" ; // echo message that there is no movie that matched the request
}
"<meta NAME=\"description\" CONTENT=\"Movie Snobs Movies Reviews by people who love movies\">
$tags \">
$page_title </title>
$title <br><b>Director:</b> $director <br><b>Written by:</b> $writer <br> <b>Main Cast:</b> $main_cast <br><b>MPAA Rating:</b>
$rating <br><b>Runtime:</b> $runtime <br> <b>Reviewed by: </b> $reviewed_by <br>
$stars .gif\" alt=\"Rating\"></center>
$release_theater <br><b>DVD Release Date:</b> $release_dvd <br><img
$netflix \" target=\"_blank\"
$title To Your Netflix Queue\">Netflix
$title </a><Br><img src=\"http://www.moviesnobs.net/images/sub_bullet.gif\" alt=\"\"> <a href=\" $amazon \" title=\"Buy $title at Amazon.com\" target=\"_blank\"
$title at Amazon</a><img
$title </span><br>
$date_written <br><br><img src=\"http://www.moviesnobs.net/images/content/email_send.gif\" alt=\"\"> <a href=\"refer_a_review.php\"
$movieid \"
$poster \" border=\"2\" align=\"right\" hspace=\"15\" vspace=\"5\"
$page_title \"> $review <p><B>See more reviews for the main cast of $title </b>: $main_cast </blockquote></blockquote>
;
// put your existing code here to display the results
}
"" ;
?>
The two includes (boxes/boxes.php) and (footer.php) don't work in the second "new" version of the code. But work flawlessly in the original. Any ideas?
07-02-06, 07:45 AM
Community Leader
Join Date: Sep 2005
Location: Spain
Posts: 8,075
Thanks: 11
Thanked 88 Times in 83 Posts
You have to break the string.
Plus, if you use single quotes to echo a string, you won't have to escape the double quotes.
Plus plus, you won't have to escape anything if you break the <?php tags.
EDIT
And you can simplify this:
To this
http://us2.php.net/manual/en/function.extract.php
Last edited by nico_swd; 07-02-06 at 07:49 AM .
07-02-06, 07:55 AM
Newbie Coder
Join Date: Jun 2006
Location: Boston
Posts: 31
Thanks: 0
Thanked 0 Times in 0 Posts
Dude, you're my hero.
07-02-06, 07:59 AM
Community Leader
Join Date: Sep 2005
Location: Spain
Posts: 8,075
Thanks: 11
Thanked 88 Times in 83 Posts
You have to keep i mind that variables won't be parsed between single quotes.
You have to break the string
07-02-06, 08:13 AM
Newbie Coder
Join Date: Jun 2006
Location: Boston
Posts: 31
Thanks: 0
Thanked 0 Times in 0 Posts
Thanks. That part I had learned from when I set up the search engine (for echoing the results page)
04-02-07, 09:52 PM
Newbie Coder
Join Date: Apr 2007
Location: Local Disk C:
Posts: 36
Thanks: 0
Thanked 0 Times in 0 Posts
here is a shortcut.
Instead of <? echo $page_title; ?> you can try
<?= $page_title; ?>
04-03-07, 05:02 AM
Community Liaison
Join Date: May 2005
Location: Antwerp, Belgium
Posts: 3,165
Thanks: 4
Thanked 25 Times in 25 Posts
Quote:
Originally Posted by
_net
here is a shortcut.
Instead of <? echo $page_title; ?> you can try
<?= $page_title; ?>
that will only work if short_open_tags is set to On
__________________
"Good judgement comes from experience, and experience comes from bad judgement." -
Fred Brooks
Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
Thread Tools
Display Modes
Linear Mode
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts
HTML code is Off
Linear Mode
