[itssami]

i wrote some code to upload the pictures to a folder and after it has uploaded, there's a page, say pics.php.. it displays all pictures of the folder to that page. now i want to add an option to delete the pictures. for example i want to add a link "Delete" under every pic, that when i click it deletes the pic from the folder and deletes the pic data from mysql.
How i can delete the pic from the folder? thanks

[Nico]

You can delete files with unlink(). But be careful. Make sure the file name passed in the URL has an image extension, and make sure the user isn't able to insert something like ?delete=../pics.php. Use basename() on the value which you receive in the URL.

This should work. (Untested)

PHP Code:

if (isset($_GET['delete']) AND preg_match('/\.(jpe?g|bmp|png|gif)$/i', $_GET['delete']))

{

    @unlink('./path/to/images/'. rawurldecode(basename($_GET['delete'])));

} 

HTML Code:

<a href="foo.php?delete=image.jpg">Delete</a>

[Bon Bon]

It should also be noted that you should restrict this feature in some form like user authentication for instance to avoid this script being used for malicious purposes.

[itssami]

but does it delete the images in the folder? or it just unlinks the images in mysql? i want to delete the image from folder as well, to save the space.

[Keith]

unlink() pertains to PHP, not MySQL. That code deletes files from the file system.

[Nico]

EDIT: A little bit too late...

This would only delete the image in the folder. I can't give you an exact code for the database task since I don't know your structure.

But something like this should work:

PHP Code:

if (isset($_GET['delete']) AND preg_match('/\.(jpe?g|bmp|png|gif)$/i', $_GET['delete']))
{
    $image = rawurldecode(basename($_GET['delete']));
    
   // Delete from folder
   @unlink('./path/to/images/'. $image);

    // Delete from database
    mysql_query("DELETE FROM your_table WHERE imagename = '". mysql_real_escape_string($image) ."' LIMIT 1") OR die( mysql_error() );
} 

[itssami]

Thanks Nico, thats what im looking for.. but im facing a problem in above code. It deletes the image from folder.. but on secong query, it gives the following error

Fatal error: Call to undefined function: mysql_real_escape_string() in

and when i try to remove that function, and write query like
DELETE FROM your_table WHERE imagename = '$image'
then it works..
can someone tell me whats wrong with that mysql_real_escape_string function ? is it syntax error or something else. thanks again.

[Nico]

With "it works", do you mean the row is being deleted from the database after running the code? Are you running a PHP version below 4.3.0? If so, try replacing mysql_real_escape_string with mysql_escape_string. If that still doesn't work, can you may post the code of the upload script?

[itssami]

it works with mysql_escape_string (it deletes the records from mysql) , and about the php version, actually i insatelled PHPTraid on my computer to practice php. i wanted to install php and mysql etc but i couldnt configure phpmyadmin. anyway thank you very very much for help.

[Nico]

If mysql_escape_string works, then are you probably running an old version. You can see that if you do a phpinfo() or phpversion() statement.

For learning purposes, I'd recommend XAMPP. It's very easy to install, and comes with everything you need.