[mdhall]

Anyone know how to implement the rename function to this setup? I want to rename files to avoid the possibility of filenames with the same name.

PHP Code:

 $file_types = array(   
     'image/pjpeg' => 'jpg', 
     'image/jpeg' => 'jpg', 
     'image/bmp' => 'bmp',
    ); 
     $fname=$_POST['fname']; 
     $picname=$_POST['picname'];
     $desc=$_POST['desc'];
    
     $max_size = 2000000;
     $filesize = $_FILES['upfile']['size'];
     $filetype = $_FILES['upfile']['type'];
     $upload_dir = $_SERVER['DOCUMENT_ROOT'] . "/files/"; 
       
        if ($filesize > $max_size){
           header ("location: size_error.php");
           exit;
        }
         if (!array_key_exists($filetype, $file_types)) { 
                header ("location: type_error.php"); 
            exit;
        } 
        else
        {   
                if (move_uploaded_file($_FILES['upfile']['tmp_name'], $upload_dir . $_FILES['upfile']['name'])) 
                { 
                $filename = $_FILES['upfile']['name'];
              include("connect.php");
              $conn = mysql_connect("localhost","$user","$pass") or die ("Could not connect to MySQL"); 
              mysql_select_db($db,$conn) or die ("Could not open database"); 
              $query = "INSERT INTO ratings VALUES('','$fname','$picname','$desc','$filename','','',now())"; 
              $result=mysql_query($query); 
      }
   }
mysql_close(); 
header ('Location: upload_success.php'); 

[Beaver]

When you say rename the image files, do you mean to a completely random filename?

[mdhall]

Yes...I tried using the randonfilename function with the above, and the files uploaded and info went into the db, but the file extension was lost when it was renamed.

[Beaver]

PHP Code:

$new_file = substr(sha1(rand(10, time())), 0, 8) . '.' . $file_types[$filetype];

rename($upload_dir . $_FILES['upfile']['name'], $new_file); 

Perhaps something like that after the if move uploaded file line.

[mdhall]

Originally Posted by Beaver

PHP Code:

$new_file = substr(sha1(rand(10, time())), 0, 8) . '.' . $file_types[$filetype];
rename($upload_dir . $_FILES['upfile']['name'], $new_file); 

Perhaps something like that after the if move uploaded file line.

if (move_uploaded_file($_FILES['upfile']['tmp_name'], $upload_dir . $_FILES['upfile']['name']))
{
$new_file = substr(sha1(rand(10, time())), 0, 8) . '.' . $file_types[$filetype];
rename($upload_dir . $_FILES['upfile']['name'], $new_file);
$filename=$new_file;


include("connect.php");
$conn = mysql_connect("localhost","$dbuser","$dbpass") or die ("Could not connect to MySQL");
mysql_select_db($db,$conn) or die ("Could not open database");
$query = "INSERT INTO items VALUES('','$fname','$title','$desc','$filename',no w())";
$result=mysql_query($query);
}

Renames if perfectly, but now the file isn't uploading.

If I change to this....

$new_file = substr(sha1(rand(10, time())), 0, 8) . '.' . $file_types[$filetype];
rename($_FILES['upfile']['name'], $new_file);

it will rename the filename put into the db and upload the pic, but the pic in the folder still has the original name.

[Beaver]

I suppose you mean, it dosen't put the new file name image into the db?

[mdhall]

Yes, the new filename will go into the database...the file put into the folder retains the users original filename.

[Beaver]

Ok when you used my first example, and say the file isn't uploading, are you sure? The reason the modified example of mine isn't working, is because its renaming something that dosen't exist. It's not looking in the $upload_dir as it should for the original, and then rename to the $new_file name.

[mdhall]

Yes, I checked the folder and the file was never uploaded into it.

[Beaver]

Ok I haven't tested this but try changing this line:

PHP Code:

if (move_uploaded_file($_FILES['upfile']['tmp_name'], $upload_dir . $_FILES['upfile']['name'])) 

to

PHP Code:

$new_file = substr(sha1(rand(10, time())), 0, 8) . '.' . $file_types[$filetype]; 

if (move_uploaded_file($_FILES['upfile']['tmp_name'], $upload_dir . $new_file))