[88mph]

using this code

PHP Code:

<?php

        $value_array = array(    'item_type',

                                'title', 

                                'brand', 

                                'model', 

                                'serial_no',

                                'replacement_cost',

                                'quantity',

                                'kit_content',

                                'main_location',

                                'current_location',

                                'notes');

        

        $inventory = mysql_fetch_array(get_all_inventory());

        foreach ($inventory as $row){

            $output = "<tr>";

            

            foreach($value_array as $cell){

                $output .="<td>{$row[$cell]</td>";

            };

            

            $output .= "</tr>";

        }

        echo $output;

        ?>

But all it seems to do is output the letter 'U' for one row of cells, rather than the content of my table

here is the code for the function get_all_inventory();

PHP Code:

function get_all_inventory() {

        global $connection;

        $query = "SELECT * 

                FROM main_inventory 

                ORDER BY item_type ASC";

        $subject_set = mysql_query($query, $connection);

        confirm_query($subject_set);

        return $subject_set;

    } 

[de.monkeyz]

PHP Code:

$output .="<td>{$row[$cell]</td>"; 

There needs to be a closing } not sure it wil fix it;

PHP Code:

$output .="<td>{$row[$cell]}</td>"; 

[88mph]

oops

and no, didn't fix it!!

is it the method that is flawed?

[de.monkeyz]

Just fetching the array once will just output one value so something like this usually:

PHP Code:

<?php
        $value_array = array(    'item_type',
                                'title', 
                                'brand', 
                                'model', 
                                'serial_no',
                                'replacement_cost',
                                'quantity',
                                'kit_content',
                                'main_location',
                                'current_location',
                                'notes');
        
          
                $result = get_all_inventory();

       while( $inventory = mysql_fetch_array($result));
        {
                   
                foreach($value_array as $cell)
                     $output .="<td>{$inventory[$cell]}</td>";
       };
            
            $output .= "</tr>";
        }
        echo $output;
        ?>

That should output all values. Although you will need to add the table header to output before the while loop


Edit:Changed the code since I think get_all_inventory() will reset the result all the time... causing an infinite loop!

[88mph]

PHP Code:

while( $inventory = mysql_fetch_array(get_all_inventory())) {
        $output = "<tr>";
            
            foreach($value_array as $cell){
                     $output .="<td>{$inventory[$cell]}</td>";
               };
            
            $output .= "</tr>";
        }
        echo $output;
        ?> 

used this (just a little doctored version of yours) and it hangs Safari

[de.monkeyz]

Yeah it's an infinite loop, I changed my code in the prev post coz I realised that

[88mph]

where is the change? I can't see why its an infinite loop?!?

[88mph]

right, used this and it worked

PHP Code:

<?php
        $value_array = array(    'item_type',
                                'title', 
                                'brand', 
                                'model', 
                                'serial_no',
                                'replacement_cost',
                                'quantity',
                                'kit_content',
                                'main_location',
                                'current_location',
                                'notes');
        
    $result = get_all_inventory();
      
    while( $inventory = mysql_fetch_array($result)) {
        $output = "<tr>";
            
            foreach($value_array as $cell){
                     $output .="<td>{$inventory[$cell]}</td>";
               };
            
            $output .= "</tr>";
            echo $output;
        }
        
        ?>

[de.monkeyz]

So no problems then? The reason it would be an infinite loop is because you would keep called get_all_inventory each time, and restart the data from entry 1, so you just get the first item over and over

[The_Demon]

hehe, that's never wanted in a script, especially if it's got a massive max runtime