[FredSmith]

Trouble passing arrays by reference (or to a function at all). Here's my code (simplified):

PHP Code:

function build_array(&$my_array, &$my_array2, &$counter) {
    while( something true ) {
        if ( condition true ) {
            $my_array1[$counter]= "some data";
            $my_array2[$counter]= "some data";
            ++$counter;
        }
    }
}

$my_array1 = array();
$my_array2 = array();
$counter = 0;
build_array ($my_array1, $my_array2, $counter);
var_dump ($my_array1); 

only returns:
array(0){}

[Jay6390]

without knowing if the condition or something are actually true, its hard to say. Chances are, they are not resolving as true

[FredSmith]

Hi Jay,

Sorry for the brevity of the script. I can echo the array element in build_array fn, but var_dump in the main doesn't produce anything useful.

I should be able to access any new elements on its return if I pass an array as part of the fn's parameter list by reference (&), right?

Fred

[FredSmith]

I added:
global $counter
to the build_array fn because echo-ing $counter revealed $counter was sometimes empty. This seems counter-intuitive to me. If its part of the parameter list and passed by reference, why should it have to be declared globally too?

[FredSmith]

adding
global $my_array1;
global $my_array2;
has seemd to clear up my problem. If there's any explaination (or link) about passing by ref and the need globals as well I would appreciate it.

thanks.

[Jay6390]

You should not need to use global. Here's an example that works without it

PHP Code:

function add_to_array(&$array,&$counter)
{
    while($counter < 5)
    {
    $array[$counter]='VALUE ADDED';
    ++$counter;
    }
}
$f = array();
$counter = 0;
add_to_array($f,$counter);
echo 'COUNTER: ',$counter,'<br />';
echo '<pre>'.print_r($f,true).'</pre>'; 

[FredSmith]

Hi Jay,

Here is the code in full, i'm sorry i didn't mention that there is a recursive call in the fn.

PHP Code:

<?php
function MakeTree($f, &$file_array, &$time_array, &$counter) {
  if (is_dir($f) ) {
    foreach(glob($f.'/*') as $sf) {
      $sf_base = basename($sf);
      if (is_dir($sf)) {
          MakeTree($sf);
      } }
      else {
          $file_array[$counter] = $sf;
          $mod_time = date("YmdB", @filemtime($sf));   //year month day swatch
          $time_array[$counter]=$mod_time;
          echo "counter ($counter)";
          echo "$file_array[$counter], $time_array[$counter]<br>";
          ++$counter;
} } }

  $root_dir = ".";
  $file_array = array();
  $time_array = array();
  $counter = 0;
  if (!$dp = opendir($root_dir)) {
    ErrorMessage("Can't open $root_dir");
  }
  else {
    while (false !== ($file = readdir($dp))) {
        if($file === '.') {
        MakeTree($file, $file_array, $time_array, $counter);
  } } }
 
  var_dump($file_array);
?>

hope this helps, sorry for not mentioning it earlier.

fred

[Jay6390]

PHP Code:

<?php
function MakeTree($f, &$file_array, &$time_array, &$counter)
{
    if(is_dir($f))
    {
        foreach(glob($f . '/*') as $sf)
        {
            $sf_base = basename($sf);
            if(is_dir($sf))
            {
                MakeTree($sf_base, $file_array, $time_array, $counter);
            }
        }
    }
    else
    {
        $file_array[$counter] = $f;
        $mod_time = date("YmdB", @filemtime($f)); //year month day swatch
        $time_array[$counter] = $mod_time;
        echo "counter ($counter)";
        echo $file_array[$counter], $time_array[$counter], "<br>";
        ++$counter;
    }
}

$root_dir = ".";
$file_array = array();
$time_array = array();
$counter = 0;
if(!$dp = opendir($root_dir))
{
    ErrorMessage("Can't open $root_dir");
}
else
{
    while(false !== ($file = readdir($dp)))
    {
        if($file === '.')
        {
            MakeTree($file, $file_array, $time_array, $counter);
        }
    }
}

var_dump($file_array);
?>

Try that. You had a number of errors in the script. one was the structure of the if's and else ifs, another was the MakeTree in the recursive function had only one parameter. Also, can you use the [PHP] [/PHP] wrappers when posting your code please

[FredSmith]

Thanks Jay! I guess I was a few parameters short a load ;-)

I will also use the wrappers in future quesitons.

Fred