[darkcarnival]

hi,

I'm trying to get a template class of mine to work correctly, but during the part of the code that should be outputting the parsed data, I get this error:

Warning: Invalid argument supplied for foreach() on line 60

now I'm using a foreach as the template will be working with loops and I'm trying to make it all work on one template file(meaning using one tremplate for a loop action not separating it into 3) as currently my template file count is at 160 and I wish to cut that down a bit for ease

now here is the template class I'm using:

PHP Code:

class templateEngine implements templateCore{



    #declare data members

    private $output;

    private $tags = array();

    private $templateFile;

    

    #function that will open template file.

    public function __construct($file){

        #see if template file exists.

        if (!file_exists($file)){

            throw new Exception('Template file ('.$file.') was not found.');

        }else{

            #get the contents of the template file

            $contents = file_get_contents($file);

            

            #see if template file is empty.

            if(empty($contents)){

                throw new Exception('Template file is empty.');

            }else{

                #Add template contents into output variable.

                $this->output = $contents;                

            }             

        }        

    }

    

    #function that will parse template tags.

    public function parseTags($tags){

    

        if(count($tags)<1){

            throw new Exception('No tags were found to be parsed.');

        }

        

        foreach($tags as $tag=>$data){

            #if data is array, traverse recursive array of tags

            if(is_array($data)){

                $this->output = preg_replace("/\{$tag/",'',$this->output);

            }

                      

            $this->output = str_replace('{'.$tag.'}', $data, $this->output);

        }    

    }

    

    #function that will output the final set.

    public function outputHtml(){

     

    $html = '';

        foreach($this->output as $val){

            $html .= $val;

        }

        return $html;

    

    }    

} 

I have tried several things and so far I haven't gotten far. I hope something here knows why this doesn't work. If you need any thing else, please let me know.

much thanks in advanced

[UnrealEd]

what exactly does your class do? does it "compile" the template files to php, or does it just parse them?

What line is line 60? There are 2 foreach loops in your code snippet, so both might cause the problem....

As for the problem itself: the reason why PHP threw this error is because the variabe you've passed on into the foreach language construct isn't either an array or an object (in your case either $tags or $this->output isn't an array or object)

[Keith]

It looks to me like $this->output is a string as opposed to an array.

You get the contents from a template file as $this->output, then modify its value in a foreach() loop. But never is $this->output converted to an array.

[darkcarnival]

what the class is suppose to do is read a template file and parse the tags.

what I want to have it do is allow loops to run without having to make additional template files and I figured the foreach would resolve that.

if anyone has a better solution, please give me your advice.
btw line 60 is this line:

PHP Code:

foreach($this->output as $val){ 

[Keith]

Read what I said just prior to your last reply. You cannot iterate a value which is not an array.

[darkcarnival]

hmm ok, alright.

now it does work without the foreach loop, only issue is, the loops don't work now

I really want to make this work(and i don't want to do the library route as most contain too much fluff or requires regular updates and I plan to use this on a programming project I work on)

does anyone have a recommendation on how I should go with this?

[darkcarnival]

hi,

had a while to think more on this and after doing some looking around I realized what I want the class to do.

basically I want the class to handle block iterations.

an example of this(in case you want to see it):

Code:

{tag.DBVALUE}

I believe phpbb 3 uses it in their script and I'd like to try something similar.

the other alternative(which I wish to avoid) is to just place php code in the template file itself, though this would break the idea of "separating the code from the design" concept I'm going with.

so going with block iterations is my next step, any idea how I can do this?

I really appreciate everyone's help

[darkcarnival]

hi,

just wanted to say thanks to those who have helped.

doing some research, I found what I was looking for to help me with my class.