[jim14]

First of all i'm new to this forum, glad i found this wonderful place. I'm also new with programming and just came across the following problem; I have a PHP script with a mysql backend, i basically want it to save the IP address and date the user last logged in. I have done the changes in red myself (see below), but it just wont work. It just doesnt save the IP Address and Date in the user table 'logindate' and 'loginip' columns. No error or anything either.

Does anyone have an idea what i'm doing wrong? Thank you in advance!

Code:

	if ($mode == "login")
	{
		if (isset ($_POST['submit']))
		{
			$email = isset ($_POST['email']) ? trim ($_POST['email']) : '';
			$password = isset ($_POST['password']) ? trim ($_POST['password']) : '';
			$captcha = isset ($_POST['captcha']) ? trim ($_POST['captcha']) : '';

			if ((empty($_SESSION['captcha_code'])) || ($_SESSION['captcha_code'] != md5 ($captcha)))
				$error = 'Invalid Verification Code';
			else
			{
				$sql = "SELECT id FROM user WHERE email = '" . sql_quote ($email) . "' AND `password` = '" . md5 ($password) . "'";
				$user_id = sql_getfield ($sql, "id");

				if ($user_id)
				{
					$session_id = md5 (uniqid() + rand(1, 9999) * time());

					$sql = "DELETE FROM user_session WHERE user_id = $user_id";
					$db->sql_query ($sql);

					$sql = "INSERT INTO user_session (user_id, session_id, date)
						VALUES ($user_id, '$session_id', " . time() . ")";
					$db->sql_query ($sql);

	$ip = $_SERVER['REMOTE_ADDR'];
	$datem = date("j F Y, g:i a");
					$sql = "UPDATE user SET logindate = $datem AND loginip = $ip WHERE $user_id = id";
					$db->sql_query ($sql);
					$_SESSION['session_id'] = $session_id;

					redirect ("./index.php");
				}
				else $error = 'Email/Password not found';
			}
		}

[End User]

Try changing this line:

$sql = "UPDATE user SET logindate = $datem AND loginip = $ip WHERE $user_id = id";

to this:


$sql = "UPDATE user SET logindate = '$datem' AND loginip = '$ip' WHERE id = '$user_id'";

[mab]

UPDATE statements operate on a coma separated list of columns. There should not be an AND between the two columns you are updating -

UPDATE [LOW_PRIORITY] [IGNORE] tbl_name
SET col_name1=expr1 [, col_name2=expr2 ...]
[WHERE where_condition]
[ORDER BY ...]
[LIMIT row_count]