[darkcarnival]

hi,

i made a whos online snipplet and im not sure if i coded it right, since i added a few things that wasnt found on the tutorial i used. heres my code plz tell if its correct or not.PS i would test it myself but i want to get this done quickly so i can have more tike t to finish the rest of the program.

PHP Code:

$time =time();

$timeout = "$time-600";



include "config.php";

$db_connection = mysql_connect ($DB_HOST, $DB_USER, $DB_PASS) or die ('Could not connect to MySQL: ' . mysql_error());



$query = mysql_query("SELECT * FROM Metal_Online WHERE Username='$username'");

$result = mysql_db_query ($DB_NAME, $query);



$del = mysql_query("DELETE FROM Metal_Online WHERE time<$timeout");

$result_del = mysql_db_query ($DB_NAME, $del);



$num_user = mysql_num_rows($result);

if (($result) && ($row=mysql_fetch_array($result)))

            {

$online = $row["Username"];

}

else

            {

              echo mysql_errno().": ".mysql_error()."<BR>";

            }



            mysql_close ();

 ?> 

the rest was just variables to display the process. so is this coded right? if not plz tell me what i missed or what i should add.thanks

[blaw]

Hello,

I think your code will probably give you an error.

Why are you using mysql_db_query() on the result? If you've queried out the result already with mysql_query(), you don't need to do it again - besides, mysql_db_query() takes an SQL statement as the second parameter - but you set the result, which is not correct.

Here's also something I quote from php.net regarding mysql_db_query():

Originally Posted by http://ca.php.net/function.mysql-db-query

Note: This function has been deprecated since PHP 4.0.6. Do not use this function. Use mysql_select_db() and mysql_query() instead.

Hope this helps. =)

[darkcarnival]

hi,

ok how should it be done? i use that kind of query in all of my programs since i found that on a tutorial. but i tried that 1 u say to try and it always says need db name so i just do it like that.

[darkcarnival]

ok i fixed the query thing so what should i do so it wont display a error?

[YourPHPPro]

Originally Posted by darkcarnival

what should i do so it wont display a error?

Havent tested this out, but this should get you started in the right direction:

Code:

<script language="php">
// No need to set time variable if we just use it once - include it in the SQL
// $time =time(); 
// $timeout = "$time-600"; 

include "config.php"; 
$db_connection = mysql_connect ($DB_HOST, $DB_USER, $DB_PASS) or die ('Could not connect to MySQL: ' . mysql_error()); 

// Since it doesnt appear that we actually need the usernames, lets just count how many there are.
$query = "SELECT COUNT(Distinct Username) AS NowOnline FROM Metal_Online WHERE time>(NOW()-600)";
$result = mysql_db_query ("$DB_NAME", "$query", $db_connection);
// Only one result, so we only need to do this one time
$Online = mysql_fetch_array($result, MYSQL_ASSOC);
//$Online["NowOnline"] should contain the total number of visitors online
// Now lets do cleanup - 5% chance of it happening.
if (rand (1,100)<=5) {
	$dump = mysql_query("DELETE FROM Metal_Online WHERE time<(NOW()-600)");
}
</script>

[darkcarnival]

ok but i think username would be needed so it can count the usersnames. also will this display the users?

[darkcarnival]

ok i fixed it up from looking at the examples giving now i have to have it display how many visitors are on my site. so how do i do that?thx.