[SOLVED] New page

tolga · #1 (**permalink**) 08-11-08, 02:56 PM

Hello,

I am pulling data from a MySQL database and displaying them on a page. I am breaking it in pages. I have this code where Sonraki (Next) link should give me next page but instead it just adds another &sayfano=1 the URL. Can you help me in this? Regards,

PHP Code:


			
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"

"http://www.w3.org/TR/html4/loose.dtd">

<head>

<meta http-equiv="content-type" content="text/html; charset=utf-8">

<link rel=stylesheet href="css/deri.css">

</head>

<div id="ana"></div>

<div id="logo"><img src="images/logo.gif" style="margin-top: -10px"></div>

<div id="kelebek"><img src="images/kelebek.jpg"></div>

<div class="dugme"><a href="modeller.html"><img src="images/modeller.gif"></a></div>

<div class="dugme"><a href="sorumvar.html"><img src="images/sorumvar.gif"></a></div>

<div class="dugme"><a href="iletisim.html"><img src="images/iletisim.gif"></a></div>

<div class="dugme"><a href="hakkimizda.html"><img src="images/hakkimizda.gif"></a></div>

<div style="float: left; margin-,top: 100px; margin-left: 10px"><img src="images/kelebek1.gif"></div>

<?php

$hedef = "foto/";

include 'baglan.php';

$durum = $_GET['durum'];

$kategori = $_GET['kategori'];

if (!(isset($sayfano))) { $sayfano = 1; }

$query = mysql_query("select id,kod,kucukfoto,fiyat,tanim from satilacak where durum='$durum' and kategori='$kategori' order by kod") or die(die);

$rows = mysql_num_rows($query);

$pagerows = 12;

$last = ceil($rows/$pagerows);

if ($sayfano < 1) { $sayfano = 1; } elseif ($sayfano > $last) { $sayfano = $last; }

$max = 'limit ' .($sayfano - 1) * $pagerows .',' .$pagerows;

$query_p = mysql_query("select id,kod,kucukfoto,fiyat,tanim from satilacak where durum = '$durum' and kategori = '$kategori' order by kod $max") or die(mysql_error());

echo "<div style=\"float: left\">";

echo "<table align=\"left\">"; 

echo "<tr>";

$i = 0;

while ($row = mysql_fetch_array($query_p)) {

$i++;

$id = $row['id'];

$kod = $row['kod'];

$kucukfoto = $row['kucukfoto'];

$tanim = $row['tanim'];

$fiyat = $row['fiyat'];

echo "<td style=\"height=100px\"><a href=\"buyukgor.php?id=$id\"><img src=\"$hedef$kucukfoto\" width=\"130\" height=\"110\"></a><div 

align=center>$kod</td>";

if($i == 4){

    echo "</tr>";

    $i = 0;

}

}

echo "</table>";

echo "</div>";

echo "<div>Sayfa: $sayfano / $last</div>";

if ($sayfano = 1) {} else { echo "<a href=\"". $_SERVER['PHP_SELF'] . "?" . $_SERVER['QUERY_STRING']. "&sayfano=1>İlk</a>";

echo "";

$prev = $sayfano - 1;

echo "<a href=\"". $_SERVER['PHP_SELF'] . "?" . $_SERVER['QUERY_STRING']. "&sayfano=$prev\">Önceki</a>";

}    

echo " ---- ";

if ($sayfano == $last) {}

else {

$next = $pagenum + 1;

echo "<a href=\"". $_SERVER['PHP_SELF'] . "?" . $_SERVER['QUERY_STRING']. "&sayfano=$next\">Sonraki</a> ";

echo " ";

echo "<a href=\"". $_SERVER['PHP_SELF'] . "?" . $_SERVER['QUERY_STRING']. "&sayfano=$last\">Son</a> ";

}

mysql_close($conn);

?>

</html>

<?Wille?> · #2 (**permalink**) 08-12-08, 12:34 AM

not sure, but your using
$prev = $sayfano - 1;
but you use
$next = $pagenum + 1;

Didnt see a $pagenum in there, but then again it was just a quick scroll trough.

ah yeah, the reason why your url looks similar to this
www.example.com?sayfano=1&sayfano=1&sayfano=1&sayfano=1&sayfano=1
is that your including $_SERVER['QUERY_STRING'] in the link without checking if sayfano is already a part of the query string

tolga · #3 (**permalink**) 08-12-08, 12:56 AM

Quote:

Originally Posted by <?Wille?>

not sure, but your using
$prev = $sayfano - 1;
but you use
$next = $pagenum + 1;

Didnt see a $pagenum in there, but then again it was just a quick scroll trough.

Ah, didn't realize that. Corrected it. This time the link is http://mtozses/deriaksesuarlar/var.p...kler&sayfano=2 but it never goes to page 2 and it continues adding &page=2 as I keep clicking that link.

Quote:

Originally Posted by <?Wille?>

ah yeah, the reason why your url looks similar to this
www.example.com?sayfano=1&sayfano=1&sayfano=1&sayfano=1&sayfano=1
is that your including $_SERVER['QUERY_STRING'] in the link without checking if sayfano is already a part of the query string

How do I check that?

Regards,

<?Wille?> · #4 (**permalink**) 08-12-08, 02:07 AM

it doesnt go to page 2 because your not using the _GET variable. instead your setting the current page to 1 here
[color=#000000]if (!(isset($sayfano))) { $sayfano = 1; }
$sayfano wont be set at this point since your not declaring it.
insert $sayfano = $_GET['sayfano']; before the if.

Quote:

Originally Posted by tolga

How do I check that?

you can remove it completely with something similar to (untested)

PHP Code:


			
$query_string = preg_replace('~(?:&?sayfano=\d+)~', '', $_SERVER['QUERY_STRING']);

and use $query_string for the rest of the script

e:
Also you are using _GET variables in the query as such which is not good. Take a look at this thread and the links in it

tolga · #5 (**permalink**) 08-12-08, 02:19 AM

I did what you said, however now it goes to page 2 only. And I can't see the links for first page and previous pages.

leeprice2006 · #6 (**permalink**) 08-12-08, 02:32 PM

I have just written a script to do what you want...

http://www.uposoft.co.uk/tutorials/pagination.php

hope that helps in someway

ianbrind · #7 (**permalink**) 08-12-08, 03:42 PM

Quote:

Originally Posted by leeprice2006

I have just written a script to do what you want...

http://www.uposoft.co.uk/tutorials/pagination.php

hope that helps in someway

Sorry it's off topic but, excelent tutorial.

leeprice2006 · #8 (**permalink**) 08-12-08, 03:50 PM

ok just thought it would help

<?Wille?> · #9 (**permalink**) 08-13-08, 01:33 AM

you cant see the previous page links because the condition for these to show is that your on he last page.
if ($sayfano == $last) {}
else {
$next = $pagenum + 1;

Abolut the tutorial:
its good overall, however there are a few problems with the tutorial.
firstly,
$totalpages = round($total / $perpage);
if you have 54 users in the database, 10 per page, you get 5.4 pages, which will round to 5. you will never be able to see the last 4 users because your using round and not ceil().

Another thing that i noticed was that you use the same query for counting and selecting but you still execute it twice, which is a waste. num_rows is probably the best way on innoDB based mysql tables but "SELECT COUNT(*)" is significantly faster on MyISAM based tables, which i belive is the default one.

tolga · #10 (**permalink**) 08-13-08, 07:32 AM

Quote:

Originally Posted by <?Wille?>

you cant see the previous page links because the condition for these to show is that your on he last page.
if ($sayfano == $last) {}
else {
$next = $pagenum + 1;

I never said I couldn't see the previous page links, but you are right I can't. What I said was Sonraki (Next) link goes to page 2 only.

Regards,

PS: And thanks goes to leeprice2006