Faster way to list dir ?

peuplarchie · #1 (**permalink**) 11-29-08, 03:28 PM

Good day to you all,
I have a piece of code which read a directory and return a list of file and folders that is with in recursively.

This code is very slow.
Maybe you can help me make it go faster ?

PHP Code:


			
<!doctype html public "-//w3c//dtd html 3.2//en">


<?php

  function CountDir($aDir, $aRecurse)
  {
    $Count = 0;

    $d = dir($aDir);

    while ($Entry = $d->Read())
    {
      if (!(($Entry == "..") || ($Entry == ".")))
      {
        if (Is_Dir($aDir . '/' . $Entry))
        {
          if ($aRecurse)
          {
            $Count += CountDir($aDir . '/' . $Entry, $aRecurse);
          }
        }
        else
        {
          $Count++;
        }
      }
    }
    
    return $Count;
  }



function getDirectory( $path = '.', $level = 0 ){




    $ignore = array( 'cgi-bin', '.', '..' );
    // Directories to ignore when listing output. Many hosts
    // will deny PHP access to the cgi-bin.

    $dh = @opendir( $path );
    // Open the directory to the handle $dh
    
    while( false !== ( $file = readdir( $dh ) ) ){
    // Loop through the directory
    
        if( !in_array( $file, $ignore ) ){
        // Check that this file is not to be ignored
            
            $spaces = str_repeat( '&nbsp;', ( $level * 4 ) );
            // Just to add spacing to the list, to better
            // show the directory tree.
            
            $rest = substr($file, 0, -4);

            if( is_dir( "$path/$file" ) ){
            // Its a directory, so we need to keep reading down...

echo '<tr><td align="left"><a href="'.$path.'/'.$file.'" align="left" class="white00" target="image">'.$spaces.'<img src="folder_icon.gif" border="0"> '.$file.'</a> - '.CountDir($path.'/'.$file, False).' </td></tr>';





                getDirectory( "$path/$file", ($level+1) );
                // Re-call this same function but on a new directory.
                // this is what makes function recursive.
            
            } else {
            


                // Just print out the filename
            
            }
        }
    }
    closedir( $dh );
    // Close the directory handle
}

getDirectory( "." );
// Get contents of the "files/includes" folder  

?>

Thanks !

End User · #2 (**permalink**) 11-29-08, 05:14 PM

I think this is reasonably snappy in terms of performance:

PHP Code:


			
<?php

// Source: Bit Repository

// URL: http://www.bitrepository.com/



function read_whole_directory($dir){

if ($handle = opendir($dir)){

$array = array();



    while (false !== ($file = readdir($handle))) {

        if ($file != "." && $file != "..") {



        if(is_dir($dir.$file)){

                     $array[][$file] = read_whole_directory($dir.$file.'/');

        }else{

                     $array[] = $file;

        }

        }

    }

    closedir($handle);

}



if(is_array($array)){

    return $array;

    }else{

    return false;

    }

}



$dir = '/your/path/to/public_html/'; // IMPORTANT: with '/' at the end



$directory = read_whole_directory($dir);



echo "<pre>"; print_r($directory); echo "</pre>";

?>

NOTE: Make sure your directory string has ‘/’ at the end.

Mike · #3 (**permalink**) 11-29-08, 08:35 PM

PHP Code:


			
$files = glob('folder_name/*.*');

echo('<pre>');

print_r($files);

echo('</pre>');

Just replace 'folder_name' with your folder.

http://us.php.net/glob

peuplarchie · #4 (**permalink**) 11-29-08, 08:39 PM

Thanks Mike and End User,
Mike how would I put my code that do a different thing when its a folder then when its a file ?

End User · #5 (**permalink**) 11-29-08, 09:46 PM

Quote:

Originally Posted by Mike

PHP Code:


			
$files = glob('folder_name/*.*');
echo('<pre>');
print_r($files);
echo('</pre>');

This code will return the contents of a single level, but it won't recursively list subfolders and the files in them (which is what the OP wanted).

Mike · #6 (**permalink**) 11-29-08, 11:23 PM

My apologies then. I misread it then. In that case... End User's solution would be the best route.

wirehopper · #7 (**permalink**) 12-02-08, 03:27 PM

Another approach would be to use Apache's mod_autoindex.

http://httpd.apache.org/docs/2.0/mod/mod_autoindex.html

Notes about autoindex.

http://know-waste.com/2008/11/26/pol...s-without-serv