[spyke01]

Hi guys im having an issue with the global keyword. Whats happening is that when i try to bring a global variable into the functions scope it just doesnt see the variable inside the file.

Ill post the full code below but heres the jist of whats happening:

a function is called to load a module, we give it prefix if we know it as well as the name of the hook that we want to call, we also pass in any paramaters it needs and we tell it if we want data back or not.

The function then looks up all modules that match our search in the database, if we find results we include the actual modules php file (this file is where things break) and then call our hook.

Heres what a call looks like

$content .= loadModules(MODULE_TYPE_PAYMENT_OPTION, "", "showButton", "", "1"); 

Heres the code for the function we just called

//=========================================================
// Load module files so we can call them
//=========================================================
function loadModules($type, $prefix, $hookToCall, $hookArguments, $returnResult) {
    global $DBTABLEPREFIX;
    $hookFunctionName = "";
    
    $extraSql = "";
    $extraSql = ($prefix == "") ? "" : " AND m.modules_prefix = '" . $prefix . "'";
    
    $sql = "SELECT ma.modules_assoc_active, m.modules_viewing_permisions, m.modules_prefix FROM `" . $DBTABLEPREFIX . "modules_assoc` ma LEFT JOIN `" . $DBTABLEPREFIX . "modules` m ON m.modules_id = ma.modules_assoc_module_id WHERE ma.modules_assoc_company_id = '" . $_SESSION['companyid'] . "' AND m.modules_type = '" . $type . "'" . $extraSql . ";"; 
    $result = mysql_query($sql);
    echo $sql . "<br />";
    
    if (mysql_num_rows($result) > 0) {
        while ($row = mysql_fetch_array($result)) {
            // We now need to cycle through our modules that match our search, if they are active 
            if ($row&#91;'modules_assoc_active'] == ACTIVE) {
                // Piece together our total function name
                
                // Get our module directory structure
                $moduleHolderDirectory = ($row&#91;'modules_viewing_permisions'] == MODULE_PERM_PUBLIC) ? "global" : $_SESSION['companyid'];
                
                switch ($type) {
                    case MODULE_TYPE_PAGE:
                        $moduleTypeDirectory = "pages";
                        break;
                    case MODULE_TYPE_PAYMENT_OPTION:
                        $moduleTypeDirectory = "payment_options";
                        break;
                    case MODULE_TYPE_GRAPH:
                        $moduleTypeDirectory = "graphs";
                        break;
                    case MODULE_TYPE_REPORT:
                        $moduleTypeDirectory = "reports";
                        break;
                    case MODULE_TYPE_REGISTER:
                        $moduleTypeDirectory = "registers";
                        break;
                    case MODULE_TYPE_USER:
                        $moduleTypeDirectory = "users";
                        break;
                    case MODULE_TYPE_INVENTORY:
                        $moduleTypeDirectory = "inventory";
                        break;
                    case MODULE_TYPE_ANALYTICS:
                        $moduleTypeDirectory = "analytics";
                        break;
                }
                
                // Include our module file
                $fullModulePath = "modules/" . $moduleHolderDirectory . "/" . $moduleTypeDirectory . "/" . $row&#91;'modules_prefix'] . ".php";
                include($fullModulePath);            
                
                // Call our hook function
                if ($returnResult == 1) {
                    /*
                    $returnVar = "";
                    eval("\$returnVar = " . $hookFunctionName . ";");
                    return $returnVar;
                    */
                    if ($hookArguments != "") {
                        $returnVar = call_user_func($row&#91;'modules_prefix'] . '_' . $hookToCall);
                    }
                    else {
                        $returnVar = call_user_func($row&#91;'modules_prefix'] . '_' . $hookToCall);
                    }
                    return $returnVar;
                }
                else {
                    eval($hookFunctionName . ";");
                }
            }
        }
        mysql_free_result($result); 
    }
} 

Heres whats breaking

//====================================
// Basic Module information
//====================================
$name = "Accept Cash";
$description = "Adds Cash to the list of accepted payment types.";
$developer = "Paden Clayton";
$version = "1.08.11.25";
$prefix = "cash";
$type = MODULE_TYPE_PAYMENT_OPTION;
$viewingPermissions = MODULE_PERM_PUBLIC;
$seperateTab = 0;
$buttonText = "Pay By Cash";
 
//====================================
// Show Button hook
//====================================
function cash_showButton() {
    global $menuvar, $prefix, $buttonText;
    
    $content = "
                <a href=\"" . $menuvar&#91;'PAYMENT'] . "&action=module&prefix=" . $prefix . "\" class=\"button\"><span>" . $buttonText . "</span></a>";
 
    return $content;
} 

The items in all caps are defined variables that get used throghuout the system. Ive could get this working by passing the variables as parameters but on a large scale this completely defeats the purpose of making a modular system and really prohibits future changes.

Any ideas on how to fix this issue?

[wirehopper]

I would place common constants such as MODULE_TYPE_PAYMENT_OPTION in a separate file that consists of all the necessary defines to support the interface, and then establish the practice that all modules must include the file with the interface constants.

[spyke01]

already got that, the constants are located in a file called constants, i can post these if you need me to.

[wirehopper]

I recommend you include or require the constants file in the file that references them.

[spyke01]

i currently use include on them, i think what is happening is that when the module file is included the global keyword becomes confused and cant properly find the right variable, i think the only way to solve this will be to create a class out of the module

[wirehopper]

The items in all caps are defined variables that get used throghuout the system. Ive could get this working by passing the variables as parameters but on a large scale this completely defeats the purpose of making a modular system and really prohibits future changes.]

Using parameters won't prohibit future changes and it may make your code more secure, more robust, and easier to maintain.

You can always extend a parameter list with default parameters, like so:

PHP Code:

function phpFunction ($parm1='default',$parm2='',$parm3=0)
{}