[jimmyjim]

Hey all,

I am trying to make a form that makes a php file and saves it to my server.
eg: 1.php

The form would have a few fields say "variable1" and "variable 2" and "save as" with a submit button.

The save as would be a text imput field where i can type in the name i want the file to be saved as eg: 1.php and the 2 other text fields would put the entered info into the php page eg: somethinggoeshere or somethingelsegoeshere

Below is how 1.php would look after the form has done its job.

PHP Code:

<?php
$variable1 = 'somethinggoeshere';
$variable2 = 'somethingelsegoeshere';
?>

I have no idea how to do this at all and am wondering if someone could help me out with it.
If you need any more info please let me know.

Any help would be much appreciated.

Thanks

[de.monkeyz]

It's just basic file methods.

PHP Code:

<?php
if(isset($_POST['save']))
{
      $dir = '/path/that/files/are/saved/'; #Leave blank if you want them in same folder.

      $first_variable = empty($_POST['first_variable']) ? '' : $_POST['first_variable'];
      $second_variable = empty($_POST['second_variable']) ? '' : $_POST['second_variable'];

       $filename = empty($_POST['filename']) ? '' : $_POST['filename'];

       $errors = array();

       if(empty($filename)) $errors[] = "Filename must be specified";
       
       $filename = $dir.$filename;

       if(file_exists($filename)) $errors[] = "That file already exists";

       if(!$errors) {

           $file = $fopen($filename, 'w');

           $contents = "<?php
         \$variable1 = '".addslashes($first_variable)."';
         \$variable2 = '".addslashes($second_variable)."';

?>"

         fwrite($file, $contents);
         fclose($file);
        }

}
?>
<?php if(!empty($errors)) {
        echo '<ul>';
        foreach($errors as $error) echo '<li>', $error, '</li>';
       echo '</ul>';
} ?>
<form action="" method="post">
<p><label>Variable one:</label><input name="first_variable" type="text"/></p>
<p><label>Variable two:</label><input name="second_variable" type="text"/></p>
<p><label>Save As:</label><input name="filename" type="text"/></p>
<p><input type="submit" name="save" value="Save"/></p>
</form>

If you look here: www.deathmonkeyz.com/tutorials in the AJAX section, I have a video on how to make a file editor with Javascript And PHP (It's called "First AJAX Application"). You can ignore the Javascript part if you wish, but the php will help.

These scripts are very unsecure at the moment however. As it allows anyone to create these files. But the code I have made only allows new files to be made, and cannot change existing files. And will only make a page defining two variables.

[jimmyjim]

Thanks for that but it does not seem to work de.monkeys i get
Parse error: syntax error, unexpected T_STRING on line 29.

Do you know what it could be?

I have no idea.

Thanks

[de.monkeyz]

I accidentally left a ; out on ?>"
Put a semi-colon at the end of line 27.

When php throws and unexpected error. It usually means a semi colon is missing. You should learn to look out for them.

[wirehopper]

If this is for a publicly accessible production system, be sure the validation is very good - otherwise, there are serious security risks.

[jimmyjim]

if i were to put it into a password protected folder would it be ok?

[de.monkeyz]

Password protected folders are very minimal when it comes to security to be honest. With something like this, I'd have the password stored in a db, with a sha512 hash on it

[jimmyjim]

for some reason now im getting
Fatal error: Function name must be a string on line 21

any ideas?

Thanks

[de.monkeyz]

I tried to call fopen, but accidentally put a $ in front of it. So it thought it had to call the contents of $fopen which is null.

Again, if it says error line:<something> and just look at that link. It's usually something obvious like this

[jimmyjim]

fantastic works well now thanks for that.