[ultimatewarrior]

Hello

This is part of my PHP code:

$badwords = "rubbish";

and another part

if($username == $badwords){

this PHP code works when you type rubbish in the username, but I want to add extra words into $badwords, but I can't, please tell me how.

if you can do this, thank you so much! thank you for saving so much time for me!


ultimatewarrior

[ruteckycs]

You need to use an array. Then loop through them:

PHP Code:

$badwords= array();
$badwords[0]="badword_here";
$badwords[1]="badword_here";
$badwords[2]="badword_here";
//do for each bad word

$i = 0;
while ($i <= count($Array)) {
  print "$Array[i]<br>";
 $i++;
} 

*This code only prints the bad words, I would have included your if statement in the code but you didnt give it all.

**This code has the bad words hard coded, if I were you I would have them saved in a DB or in a flat file even for easy updating.

[wirehopper]

PHP Code:

$aBad=array('password','notnice','ugly', ...);  /* All lowercase */

/* Make username lowercase for comparison */

if (in_array(strtolower($slc),$aBad)) die('Bad username'); 

[ruteckycs]

First time I have heard about in_array() this is a good example of me doing things the 'hard way'. Question about it though. Is the same running time as a bunch of ifs or is this faster?

[Nico]

It's much faster.

Make sure to trim() the username as well.

[PopSmith]

Is it recommended to use in_array() even if the list is somewhat lengthy, as in over 20-30 items?

I don't intend on having a list that long, because strlower() eliminates the need to check multiple variations based on capitalization, but I'm just curious.

Also, is it possible to check the input for things such as underscores or dashes between letters of "banned" words? (i.e.
user-name, user_name, u_sern_ame etc.) or would you recommend letting people use them?

[ruteckycs]

20-30 is not a long list. When I said a long list in my post to wirehoper I was thinking 15,000 or so.

You can use remove any underscores

PHP Code:

preg_replace("-", "", $user_name); 

You can make it to remove multiple things (underscore , dashes , dots, commas)

PHP Code:

preg_replace("-,.", "", $user_name); 

[PopSmith]

Thanks ruteckycs. I wasn't sure what was considered a "long" list and accidentally left off a zero in my post.

But if you consider something like 15,000 a long list then I won't have to worry about it for my purposes. Thanks for the help on removing characters from input via preg_replace.

[wirehopper]

Nico - good point about trim.

PHP Code:

$aBad=array('password','notnice','ugly', ...);  /* All lowercase */ 

/* Make username lowercase for comparison */ 

if (in_array(strtolower(trim($slc)),$aBad)) die('Bad username'); 

If you find you have a really long list, I'd store it in a text file and use grep, on the commandline. It's unlikey you'll ever need it.

[ultimatewarrior]

Thanks! I will try them out! =D