[cedricmeier12345]

Hello everyone,

I have the code below that will create a random password for me. I have the codelenght variable set to 10 which creates a random password with 10 characters maximum. The only problem is that sometimes it will create a password with less than 10 characters. How do i edit this so it will always create a random password of exactly 10 characters?

Thanks so much for any help you can provide. I have been at this for a while and don't know where to go from here!


<?
$codelenght = 10;
while($newcode_length < $codelenght) {
$x=1;
$y=3;
$part = rand($x,$y);
if($part==1){$a=48;$b=57;} // Numbers
$code_part=chr(rand($a,$b));
$newcode_length = $newcode_length + 1;
$newcode = $newcode.$code_part;
}
?>

[Jcbones]

Not my function, although I did add some functionality to it. But, it works, and will return a totally random password, and you can set the length.

PHP Code:

function createRandomPassword() {
$length = 10;  //length of password;
    $chars = "abcdefghijkmnopqrstuvwxyz023456789";
    srand((double)microtime()*1000000);
    $i = 0;
    $pass = '' ;
    while ($i <= $length) {
        $num = rand() % 33;
        $tmp = substr($chars, $num, 1);
        $pass = $pass . $tmp;
        $i++;
    }
    return $pass;
} 

[Keith]

PHP Code:

function random_password( $length = 10 )
{

    $length = ( int ) $length;

    $chars = array_merge(
        range( 'A', 'Z' ),
        range( 'a', 'z' ),
        range( '0', '9' )
    );

    $pass = '';

    while ( $length > strlen( $pass ) )
    {
        $pass .= $chars[ array_rand( $chars ) ];
    }

    return $pass;

} 

[wirehopper]

PHP Code:

while ( $length > strlen( $pass ) )

    {

        $pass .= $chars[ array_rand( $chars ) ];

    } 

could be:

PHP Code:

$pass=substr(shuffle($chars),0,$length-1); 

PHP: shuffle - Manual

[Keith]

Originally Posted by wirehopper

PHP Code:

while ( $length > strlen( $pass ) )
    {
        $pass .= $chars[ array_rand( $chars ) ];
    } 

could be:

PHP Code:

$pass=substr(shuffle($chars),0,$length-1); 

PHP: shuffle - Manual

Have you read that link you'd provided? shuffle() returns boolean, it's argument is passed as a reference.

And $chars is an array... substr() accepts a string as it's first argument.

[wirehopper]

Ooops.

General idea was to use a library function instead of a loop.

I stand corrected.

PHP Code:

$pass=substr(shuffle($chars),0,$length-1); 

Should be

PHP Code:

$pass=substr(str_shuffle($chars),0,$length-1); 

PHP: str_shuffle - Manual