Set Cookie.. not setting

timbaker1991 · #1 (**permalink**) 01-27-11, 01:39 PM

I've got this code to set a cookie with information from a GET form but just doesn't work? Tested in Firefox, Chrome and Opera, oh an IE.

If anyone could offer any advice be grateful

PHP Code:


			
<!DOCTYPE html><html lang="en"><head>

<meta charset="utf-8"><meta name="generator" content="CoffeeCup HTML Editor (www.coffeecup.com)">

<LINK href="style.css" rel="stylesheet" type="text/css">

</head><body><?php include error_reporting(0); ?>

<div id="content"><div id="headerholder"><div id="location">

&nbsp; <?php echo $_GET['loc']; ?><!--<form method="post" action="request.php"><input type="submit" name="submit" value="Change"></form>--></div>

<div id="options"><form action="changes.php"><input type="submit" name="submit" value="Updates"></form></div></div>

<div id="elementholder"></div>

<?

$location = $_GET['loc'];

setcookie("weather",$location);



?>

  

  </body>

</html>

I know the get form works as I can see the results in the url of the page

UnrealEd · #2 (**permalink**) 01-27-11, 04:14 PM

Quote:

Originally Posted by http://www.php.net/setcookie

setcookie() defines a cookie to be sent along with the rest of the HTTP headers. Like other headers, cookies must be sent before any output from your script (this is a protocol restriction). This requires that you place calls to this function prior to any output, including <html> and <head> tags as well as any whitespace.

PHP: setcookie - Manual

Your code is probably throwing errors, but via the php settings error showing is probably turned off by default. That's why it seemed like it worked, but wasn't. To enable error showing, place the following lines at the top of your script:

PHP Code:


			
ini_set ('display_errors', '1');

error_reporting (E_ALL | E_STRICT);

timbaker1991 · #3 (**permalink**) 01-27-11, 04:33 PM

Hi, I've done so and I now have this error produced

Warning: Cannot modify header information - headers already sent by (output started at /home/content/22/6620922/html/webos/apps/weather/sandbox/rememberlocation/display.php:4) in /home/content/22/6620922/html/webos/apps/weather/sandbox/rememberlocation/display.php on line 22

What would you think that would mean in real terms?

Thanks, Tim

job0107 · #4 (**permalink**) 01-27-11, 05:34 PM

I am assuming you are getting to this page from another page because I see no input element named "loc".
But the problem is that you have output before the setcookie() command is executed.
That is not allowed.
Put that code before everything else and it should work.

PHP Code:


			
<?
$location = $_GET['loc'];
setcookie("weather",$location);
?>
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8"><meta name="generator" content="CoffeeCup HTML Editor (www.coffeecup.com)">
<LINK href="style.css" rel="stylesheet" type="text/css">
</head>
<body>
<?php include error_reporting(0); ?>
<div id="content">
 <div id="headerholder">
  <div id="location">
  &nbsp; <?php echo $_GET['loc']; ?>
  <!--
  <form method="post" action="request.php">
  <input type="submit" name="submit" value="Change">
  </form>-->
  </div>
 <div id="options">
 <form action="changes.php">
 <input type="submit" name="submit" value="Updates">
 </form>
 </div>
</div>
<div id="elementholder"></div>
</body>
</html>

timbaker1991 · #5 (**permalink**) 01-27-11, 05:49 PM

Yeh it does come from another page! thanks works like a treat

job0107 · #6 (**permalink**) 01-27-11, 06:05 PM

One more thing.
I just noticed that you are using short php opening tags (<?).
Though it may work with the server you are using, some servers don't allow the short tags.
You should get used to using the long tag (<?php), that way you won't have problems if you need to switch servers that don't allow the short tag.