[Frank]

Hi everyone, I am currently working to do my webpage using a templating system which will replace tags by text (ie: {HOME} to "Home") and it's doing good

The only problem I have now is when I want to replace one tag with lots of text such as tables with data. I tried this in a loop so it would do the same thing for every row of data that is in the mySQL table.

PHP Code:

$temp = '<p align="left"><b>[<u>'. $myrow['id'] .'</u>]</b> '. nl2br($myrow['text']) .'</p>'.

$blabla = "$blabla$temp"; 

As you can see, it should replace $temp with the informations from the row in the mySQL table then add it to the $blabla variable right after the previous informations from the previous row(s). Like I said, it should work like this but it doesn't work like I thought it would work!

The code will show rows id: #1, #2, #1, #3, #1, #2 and #1 in this order when it should show all 5 rows and never repeat the same one. My table has 5 rows and it never showed me the fifth one.

Can anyone help me? Or does anyone know any other way to have a lot of data in a single variable?


Thanks all, Frank

[NeverMind]

use the dot operator..

PHP Code:

//note the dot before equal sign

$temp .='<p whatever'; 

this way, PHP will append the new text at the end of the variable ..
it's that simple

[Frank]

Hmm, it doesn't work, it adds even more text to the table (1,1,1,2,1,1,1,1,2, etc.)

Here's the full code of the loop:

PHP Code:

$news = mysql_query('SELECT * FROM scorp_news',$db);

if ($myrow = mysql_fetch_array($news)) {

    do {

        $temp .= '<p align="left"><b>[<u>'. $myrow['id'] .'</u>]</b> '. nl2br($myrow['text']) .'</p>'.

        $blabla .= $blabla . $temp;



        } while ($myrow = mysql_fetch_array($news));

        $text .= '<div align="center"><table border="1" cellpadding="0" cellspacing="0" style="border-collapse: collapse" bordercolor="#111111" width="20%" height="20%"><tr><td width="20%" height="20%" valign="top">'. $blabla .'</td></tr></table></div>';

    } else {

        echo 'cannot connect db';

        } 

By the way, this code is still a big draft.. I did try to modify the code to make it work in other ways but it always output a few times the same rows. Looks like it's always adding $blabla after $blabla itself, which doubles the data with the same data but it shouldn't do this! What do you think?


I would be glad if you could help me fixing this code
Thanks, Frank

[blaw]

Hi there,

Originally Posted by Frank

Looks like it's always adding $blabla after $blabla itself, which doubles the data with the same data but it shouldn't do this! What do you think?

As NeverMind said, $foo .= $bar will append $bar to $foo, so if you wrote:

PHP Code:

$blabla .= $blabla . $temp; 

It's the same as this:

PHP Code:

$blabla = $blabla . $blabla . $temp; 

So what you want to do is this:

PHP Code:

$blabla .= $temp; 

Hope this helps.

[Frank]

Thanks for the informations Blaw, it clarified a few things in my head now

I did what you told me and it still does the same thing, here's the modified code:

PHP Code:

$news = mysql_query('SELECT * FROM scorp_news ORDER BY id ASC',$db);

if ($myrow = mysql_fetch_array($news)) {

    do {

        $temp = '<p align="left"><b>[<u>'. $myrow['id'] .'</u>]</b> '. nl2br($myrow['text']) .'</p>'.

        $blabla .= $temp;

        } while ($myrow = mysql_fetch_array($news));

        $text = $blabla;

    } 

This code shows rows 1,2,1,3,1,2,1 in this order and then stops. It stops after 7 loops when there are 5 rows in the table and there is nothing in the code that tells it to stop after the seventh loop!


Anyone got a clue on this? Thanks, Frank

[blaw]

Hi there,

Why do you have period after '</p>' ? Isn't it supposed to be semi-colon?

Anyway, you can surely achieve what you're doing with your approach, but more common one would be to use while loop this way:

PHP Code:

<?php



$news = mysql_query('SELECT * FROM scorp_news ORDER BY id ASC',$db);



// Initialize the output var.

$text = '';



// Check if there is at least one row returned.

if (mysql_num_rows($news) > 0) {

    // Yes, there is.

    while ($myrow = mysql_fetch_array($news)) {

        // Repeat the following until there is no more row to fetch.

        $text .= '<p align="left"><b>[<u>'. $myrow['id'] .'</u>]</b> '. nl2br($myrow['text']) .'</p>';

    }

}





// In the end, you have $text that holds all the output from the database, formatted.

echo $text;



?>

In addition, you don't even need to check the num_rows if you are sure that there is always going to be 5 rows (or at least one row) returned from the query.

HTH.

[Frank]

Errm, the period after '</p>' was a typo error, thanks for pointing it out.

I tried your code and it WORKS! Wow, I still don't know what was the problem with my code, I'll comment it out and take a look at it in the near future.


Thanks for the help everyone! Frank