[AdrianLewis]

Hi All,

I am at my wits end with some code for a website I am working on. The page in question is simply for a user to add items to a list of data. The data is stored in a temp file and later added to a database. I have successfull set the page to add items to the list of data. My issue is with trying to remove a line of data from the file. The following snippet of code runs if a link has been clicked on the line of data to be removed which reloads the page running this code which is intended to remove that line...

PHP Code:

if ( isset($RemoveLine) ) {

    //file() opens a file and puts the content in an array 

    //each element of the array is a line 

    $fileText = file($filename);

    $CheckLine = 0;

    //open the file again 

    $f = fopen($filename, 'w');

    foreach($fileText as $line){

        $Checkline = $Checkline + 1;

        if ($CheckLine <> $RemoveLine){

               fputs($f,$line); //place $line back in file 

               }

    }

    fclose($f);



    unset($RemoveLine);

} 

Before clicking the link to remove a line my page displays the following detail for example...

Qty Code Description Unit Price (£) Total (£) + V.A.T
2 2 2 2 2 0.33 Remove Item
3 3 3 3 3 0.495 Remove Item
4 4 4 4 4 0.66 Remove Item

However after clicking Remove Item (for this example I clicked Remove Item on the second line) the page reloads with the following...

Qty Code Description Unit Price (£) Total (£) + V.A.T
2 2 2 2 2 0.33 Remove Item
3 3 3 3 3 0.495 Remove Item
4 4 4 4 4 0.66 Remove Item
4 4 4 4 0 Remove Item

I have checked the temp file being used and the data matches that displayed...

2, 2, 2, 2, 2, 17.5
3, 3, 3, 3, 3, 17.5
4, 4, 4, 4, 4, 17.5
4, 4, 4, 4, ,

Annoyingly my remove item link is adding another line instead of removing the chosen line.

Any help with this would be fantastic.

Thanks

Adrian

[End User]

Why not use a temp table to store the data? It woul eliminate a whole buch of the issues you're dealing with.

[AdrianLewis]

Thanks for your tip. will consider that as an option, just seemed a simpler option for a number of reasons.

Ta

[mab]

I tried a version of your code and it works.

I could not duplicate your problem (of adding a line at the end of the file), but I suspect that what it is doing is reading all the file into the 1st element of the array. I think the end of lines in the file are not being recognized. To check this I would add the following after the file() statement -

PHP Code:

echo count($fileText)."<br />"; // show how many lines it found 

Another possibility is that the file is still open (there is no fclose($f); following the file() statement) when you try to open it for writing. On my system this did not cause a problem. On your system, who knows?

Another problem is in your checkline variable. It changes between CheckLine and Checkline several times. This should have caused an error (it did on my system), but the error level setting would affect if you get an error.

Lastly, there could be a problem with the file permissions. As always, function calls should have error checking and reporting done on the results.

Here is the slightly modified version of your code that I tested with -

PHP Code:

<?php



$filename = "atext.txt";

$Removeline = 7;

$f = fopen($filename, "r") or die("could not open $filename for read<br />");



$fileText = file($filename); 

echo count($fileText)."<br />"; // show how many lines it found

fclose ($f);



$Checkline = 0; 

$f = fopen($filename, 'w') or die ("could not open $filename for write<br />");



foreach($fileText as $line){ 

$Checkline = $Checkline + 1; 

    if ($Checkline <> $Removeline){ 

        fputs($f,$line); //place $line back in file 

    } 

} 

fclose($f); 

echo "done";

?>

[AdrianLewis]

Hi Mab,

Fantastic, schoolboy error really but you spotted it. It was the variable $CheckLine.

As for my code adding that additional line each time. I think it is coming from another part of my page but I'm tracking it down.

Thanks for your help with this and your time. Much appreciated.

Adrian

[AdrianLewis]

All sorted. Managed to find my dodgy code that was adding another line.

Just wanted to thank you again, been stuck with this for ages. Needed another persons eye to spot the terrible coding.

:¬)

Thanks

Adrian