[Niall]

I'm sure this is going to be another of my "ask for help and then realise I was being moronic" posts, but I have a very strange problem with one of my scripts:

PHP Code:

if($stored_pass == $password){
    $_SESSION['user'] = $user['id'];
    $_SESSION['HTTP_USER_AGENT'] = sha1(md5($_SERVER['HTTP_USER_AGENT']));
    $log_details = "Logged In";
    include("update_activity_log.php");
    
    header('Location: '.$return_url.'');
    exit;
}
else{
    $_SESSION['login'] = $_SESSION['login'] +1;
    $log_details = "Failed to log in (incorrect username or password)";
    include("update_activity_log.php");
    header('Location: /pages/login.php?return='.$return_url.'&error=true7');
    exit;
}; 

Ok, the problem is when I use the correct login details, both the True and the False parts of the script are run. It logs me in and then sends me back to the login page with an error telling me I entered the wrong details.
I have verified that the script is correctly receiving the entered password (hashed) and the password stored on the database (also hashed) and they are exactly the same.
I've also tried this with seperate IF statements instead of an IF ELSE statement, but I get the same problem.

[Niall]

On further investigation I found a workaround, but I still don't know why the system isn't being logical.
I discovered that the login script wasn't receiving the return URL properly, so was returning the user to the login page after they had logged in.
Well, as predicted this is a "just realised I'm a moron" thread!

[Frement]

When it returns to the same page, first it checks that the login details are correct, and redirects to the same page, which then checks that the login details are incorrect (not filled in) and tells you that the information is wrong. But it still sets the session values correctly.

I hope this made some sense.

[Niall]

Originally Posted by Frement

When it returns to the same page, first it checks that the login details are correct, and redirects to the same page, which then checks that the login details are incorrect (not filled in) and tells you that the information is wrong. But it still sets the session values correctly.

I hope this made some sense.

I had to read it a couple of times, but I think I get it. Thanks.